Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: hardcode max vm cycles in keeper" #1902

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

ajnavarro
Copy link
Contributor

Reverts #1807

This PR is causing problems in some realms because the maximum limit is too low.

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 8, 2024
@ajnavarro ajnavarro changed the title Revert "fix: hardcode max vm cycles in keeper" fix: Revert "fix: hardcode max vm cycles in keeper" Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 45.04%. Comparing base (69811ff) to head (703c525).

Files Patch % Lines
gno.land/pkg/gnoland/node_inmemory.go 0.00% 5 Missing ⚠️
gno.land/pkg/gnoland/app.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1902      +/-   ##
==========================================
- Coverage   47.74%   45.04%   -2.70%     
==========================================
  Files         393      464      +71     
  Lines       61629    67983    +6354     
==========================================
+ Hits        29424    30623    +1199     
- Misses      29734    34787    +5053     
- Partials     2471     2573     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn
Copy link
Contributor

leohhhn commented Apr 8, 2024

Let's merge this and make an analysis on gas/cpu cycle usage, and think of more appropriate numbers from that.

@ajnavarro ajnavarro merged commit 91a50d5 into master Apr 8, 2024
184 of 185 checks passed
@ajnavarro ajnavarro deleted the revert-1807-bug/infinite-cycles branch April 8, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants