fix: Increase the max gas limit to 10000M. #1901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We changed the default gas limit to a fixed value on the code. That is causing problems in some realms because the maximum limit is too low. Increasing the limit temporarily until we do some measurements and specifically know what is a sane max limit on gas usage. Signed-off-by: Antonio Navarro <[email protected]>
ajnavarro
requested review from
jaekwon,
piux2,
moul and
zivkovicmilos
as code owners
ajnavarro
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1901 +/- ##
=======================================
Coverage 47.74% 47.74%
=======================================
Files 393 393
Lines 61629 61629
=======================================
Hits 29424 29424
Misses 29734 29734
Partials 2471 2471 ☔ View full report in Codecov by Sentry. |
|
Shouldn't we need to change these lines too?? gno/gno.land/pkg/gnoland/node_inmemory.go Line 44 in 69811ff gno/gno.land/cmd/gnoland/start.go Line 293 in 69811ff |
|
Superseded by #1902 |
6 tasks
zivkovicmilos
pushed a commit
that referenced
this pull request
May 15, 2024
closes #1788 similar closed pr #1901 This pr bumps 2 maximum limits 1. max block gas 2. max vm cycle AFAIK, to use amount of increased gas, vm cycle also need to be bump too. This is temporarily fix pr until we have clear ways to measure gas usage and vm cycle. <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
May 21, 2024
…g#2065) closes gnolang#1788 similar closed pr gnolang#1901 This pr bumps 2 maximum limits 1. max block gas 2. max vm cycle AFAIK, to use amount of increased gas, vm cycle also need to be bump too. This is temporarily fix pr until we have clear ways to measure gas usage and vm cycle. <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the default gas limit to a fixed value on the code.
That is causing problems in some realms because the maximum limit is too low.
Increasing the limit temporarily until we do some measurements and specifically know what is a sane max limit on gas usage.
BREAKING CHANGE: Hardcoded max gas limit changed.
Related: #1873
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description