chore(misc/autocounterd): init autocounterd #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albttx
force-pushed
the
misc/autocounterd
branch
from
7af582a
to
6ac54ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1612 +/- ##
==========================================
+ Coverage 47.74% 47.79% +0.05%
==========================================
Files 393 393
Lines 61629 61731 +102
==========================================
+ Hits 29424 29505 +81
- Misses 29734 29750 +16
- Partials 2471 2476 +5 ☔ View full report in Codecov by Sentry. |
albttx
force-pushed
the
misc/autocounterd
branch
2 times, most recently
from
2fd9f08
to
310f716
Compare
thehowl
reviewed
Feb 8, 2024
thehowl
reviewed
Feb 8, 2024
thehowl
reviewed
Feb 20, 2024
albttx
force-pushed
the
misc/autocounterd
branch
from
e9d6197
to
27eaf9c
Compare
thehowl
reviewed
Feb 28, 2024
|
@thehowl Can this be merge ? |
|
@albttx We need a second review 🥲 (I pinged the team on monday) |
harry-hov
approved these changes
Mar 19, 2024
albttx
force-pushed
the
misc/autocounterd
branch
from
b8dbdd1
to
cc6184c
Compare
|
@thehowl @zivkovicmilos All good, all fixed, ps: sorry for --rebase push force 🙈 |
|
@albttx Otherwise we're good to merge |
|
@zivkovicmilos good :) |
Co-authored-by: Hariom Verma <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A demo is currently running on the portal loop
you can check https://portal.gnoteam.com/r/portal/counter
close: #1443
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description