Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(misc/loop): updates images, fix flags config #1907

Merged
merged 4 commits into from
May 27, 2024

Conversation

albttx
Copy link
Member

@albttx albttx commented Apr 9, 2024

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@albttx albttx requested review from moul and a team as code owners April 9, 2024 09:14
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.08%. Comparing base (1a53255) to head (fa4193b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1907      +/-   ##
==========================================
- Coverage   49.09%   49.08%   -0.01%     
==========================================
  Files         576      576              
  Lines       77821    77821              
==========================================
- Hits        38204    38198       -6     
- Misses      36523    36528       +5     
- Partials     3094     3095       +1     
Flag Coverage Δ
contribs/gnodev 24.18% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 61.62% <ø> (ø)
gnovm 42.23% <ø> (+0.01%) ⬆️
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 73.90% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.38% <ø> (-0.31%) ⬇️
misc/loop 0.00% <ø> (ø)
tm2 54.53% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albttx albttx requested a review from a team as a code owner April 24, 2024 21:21
@albttx
Copy link
Member Author

albttx commented Apr 24, 2024

All good for review: @harry-hov

@albttx albttx requested a review from harry-hov April 24, 2024 21:22
@zivkovicmilos zivkovicmilos merged commit ff61f86 into master May 27, 2024
81 checks passed
@zivkovicmilos zivkovicmilos deleted the fix/loop-autocounterd branch May 27, 2024 11:30
omarsy pushed a commit to TERITORI/gno that referenced this pull request Jun 3, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants