-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement ./contribs/gnodev
command
#1386
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
- Coverage 56.32% 56.30% -0.02%
==========================================
Files 422 422
Lines 65699 65699
==========================================
- Hits 37003 36993 -10
- Misses 25815 25821 +6
- Partials 2881 2885 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
c30466a
to
d17775c
Compare
Signed-off-by: gfanton <[email protected]>
ab23990
to
9829fe3
Compare
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this PR and recommend gathering community feedback and iterating on it.
It would be helpful to move most of the new logic to contribs/
and create a separate go.mod file. This enables further optimizations while keeping gnovm and gno.land minimalistic.
After moving to contribs/
, we should thoroughly review the changes in gnovm/
and gno.land/
, and perform a light round of checks on the contribs/
folder before merging and iterating.
@moul that's make perfect sense, I will move this to |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
./contribs/gnodev
command./contribs/gnodev
command
Signed-off-by: gfanton <[email protected]>
Signed-off-by: moul <[email protected]>
….mod Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
@zivkovicmilos @ajnavarro, just wanted to let you know that we encountered a problem while importing tx-archive. It seems that tx-archive imports gno. I suggest we relocate all the tx-archive logic to this repository and reserve the tx-archive repository for specific purposes like releases, or delete it. |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
We'll consider opening a PR to migrate out both |
Signed-off-by: gfanton <[email protected]>
Introducing
gnodev
CommandThis PR introduces the
gnodev
command, designed to facilitate the development and iteration of realms package. Its primary role is to operate an in-memory node along agnoweb
server.Key features of this command include:
Recursive Monitoring: It continuously monitors the example packages folder for any file changes. Moreover, it offers the flexibility for users to monitor and add directories outside the example folder by specifying them as arguments.
Dynamic File Change Response: When a file change is detected,
gnodev
endeavors to reload the affected package and restart the node. In an effort to maintain the current state, it will try to reapply all previous blocks.Interactive Controls: Users have the ability to reload the node at any moment by pressing
R
and can reset the current node state usingCtrl+R
.Command Flags:
-minimal
flag, which prevents the node from loading the example folder.-no-watch
flag, used to disable the automatic file change monitoring feature.Additionally, any raw arguments passed to the command will be considered as packages path and will be loaded into the node.
ref: #1174
GnoWeb package
This PR also introduce GnoWeb package since it's now running in
gnoweb
andgnodev
command.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description