Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribs/gnodev: start node even if the package fails to publish #1447

Closed
harry-hov opened this issue Dec 16, 2023 · 1 comment · Fixed by #1456
Closed

contribs/gnodev: start node even if the package fails to publish #1447

harry-hov opened this issue Dec 16, 2023 · 1 comment · Fixed by #1456
Assignees
Labels
🐞 bug Something isn't working

Comments

@harry-hov
Copy link
Contributor

Currently, if the gnodev command fails to publish any package, Node fails to start. In my opinion, it should still start the Node even if it fails to publish the package and keep watching/monitoring the given package. It should still be able to hot reload.

Here is an example where a Realm developer will not be able to watch the Realm:

Imagine:

  • I'm working on some package, helloworld, and it uses p/avl.
  • Let's say there is some problem in r/boards (that exists in the example directory).

In the above scenario, if I run gnodev path/to/helloworld, it won't be able to start the Node, saying there is an error in loading r/boards, blah blah blah... even if helloworld never imports r/boards.

PS: Thanks @gfanton for #1386 ❤️

@gfanton
Copy link
Member

gfanton commented Dec 18, 2023

Good point, i've made a PR #1456 to set SkipFailingGenesisTxs to true by default in the genesis file, do you think it's worth it to make this optional ?

@zivkovicmilos zivkovicmilos added the 🐞 bug Something isn't working label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Status: 🌟 Wanted for Launch
Development

Successfully merging a pull request may close this issue.

3 participants