RFC(philosophy): Merge some standalone repos into this monorepo #2337
Assignees
Milestone
Comments
moul
changed the title
7 tasks
zivkovicmilos
added a commit
that referenced
this issue
Jun 24, 2024
## Description After thorough discussions with @moul, this PR migrates the repo contents of [libtm](https://github.com/gnolang/libtm) (currently private) to the gno monorepo, under `tm2/pkg/libtm`, while preserving the original git history. We envision this library being used outside the `gno` repo, and have thus migrated its original `go.mod`. Please reference the `README.md` for additional details Related: - #2337 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Petar Dambovaliev <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
gfanton
pushed a commit
to gfanton/gno
that referenced
this issue
Jul 23, 2024
## Description After thorough discussions with @moul, this PR migrates the repo contents of [libtm](https://github.com/gnolang/libtm) (currently private) to the gno monorepo, under `tm2/pkg/libtm`, while preserving the original git history. We envision this library being used outside the `gno` repo, and have thus migrated its original `go.mod`. Please reference the `README.md` for additional details Related: - gnolang#2337 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Petar Dambovaliev <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we have several standalone repos (
tx-indexer,tx-archive,faucet,gnora,libtm,p2p) that could be merged into the monorepo. While in the future we may split them out, for now, keeping them separate creates diamond dependencies issues and inconsistency in releases. This makes it risky, limiting or even impossible to depend on one of these standalone repos and the monorepo at the same time.Moreover, having these repos separate hides whether or not something is still compatible with the latest master. Switching to a monorepo would ensure that we're consistent with devs, versioning, breaking changes, and always testing all our tools.
For now, it seems smarter to rely on a single versioning system across the ecosystem rather than expecting to have independent versions that are actually always depending on each other. Therefore, I propose that we merge these standalone repos into the monorepo and encourage all {tm2,gno}-core related projects to start from the monorepo first as the default rule.
The text was updated successfully, but these errors were encountered: