Disable File Open menu item #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the `java.security.AccessControlException: access denied` exception.
| openMenu.add(menuItem("File...", 'F', KeyStroke.getKeyStroke(KeyEvent.VK_O, CMD_CTRL_KEY_MASK), this.actionPool.openFileAction)); | ||
| final JMenuItem fileMenuItem = menuItem("File...", 'F', KeyStroke.getKeyStroke(KeyEvent.VK_O, CMD_CTRL_KEY_MASK), this.actionPool.openFileAction); | ||
| // TODO enable the menu item once access control UI is implemented | ||
| fileMenuItem.setEnabled(false); |
There was a problem hiding this comment.
Was thinking if we should pass in a flag to menuItem to return a disabled item, or use disabled action. Let me know what you think about it.
There was a problem hiding this comment.
A flag to menuItem would be more "functional", yeah. But if it is used only in this one case, I would leave it aside as a minor thing.
There was a problem hiding this comment.
Makes sense. Will check for usage and see if we can get that done.
|
Merged; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the
java.security.AccessControlException: access deniedexception.
Closes #132