Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu File -> Open File... should be disabled until it works #132

Closed
hrj opened this issue Aug 5, 2015 · 6 comments
Closed

Menu File -> Open File... should be disabled until it works #132

hrj opened this issue Aug 5, 2015 · 6 comments
Labels
usability
Milestone
0.3.12

Comments

@hrj
Copy link
Member

hrj commented Aug 5, 2015 •
edited
Loading

Clicking on File -> Open File throws an exception because of strict access control. Need to work an access control UI, but until then the menu button can be simply disabled / hidden.
@hrj hrj added the usability label Aug 5, 2015
@hrj hrj self-assigned this Aug 5, 2015
@hrj hrj added this to the 0.4 milestone Aug 5, 2015
@hrj
Copy link
Member Author

hrj commented Sep 13, 2015

The menu entry has been disabled for now.

@hrj hrj removed their assignment Sep 13, 2015
@chetankothari
Copy link
Contributor

@hrj I just checked this and see that the menu item is neither disabled nor hidden. I would be able to do either if required.

@hrj hrj changed the title Menu File -> Open should be disabled until it works Menu File -> Open File... should be disabled until it works Aug 24, 2016
@hrj
Copy link
Member Author

hrj commented Aug 24, 2016

@chetankothari good catch! I don't know why I wrote "it has been disabled". 😕

Please go ahead and disable it. Note that only Open File action needs to be disabled. It can be triggered either through File menu -> Open -> File... option or via Ctrl-O shortcut.

Thanks!

@chetankothari chetankothari mentioned this issue Aug 24, 2016
Merged
@chetankothari
Copy link
Contributor

chetankothari commented Aug 24, 2016 •
edited
Loading

@hrj do we have a release branch against which the PR should be raised? I have raised it against master. Let me know if I have to change that. here is the pr #217

@hrj hrj closed this as completed in #217 Aug 24, 2016
@hrj
Copy link
Member Author

hrj commented Aug 24, 2016

master was the appropriate branch. Currently, whatever is on master branch gets included in the next release (along with some WIP patches).

@chetankothari
Copy link
Contributor

Cool.

@hrj hrj modified the milestones: 0.3.12, 0.4 Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
usability
Projects
None yet
Milestone
0.3.12
Development

No branches or pull requests
2 participants
@hrj @chetankothari