Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for attribute values with pixels #186

Closed
wants to merge 22 commits into from

Conversation

atiqsayyed
Copy link
Contributor

fixed #167

@hrj
Copy link
Member

hrj commented Oct 23, 2015

Oh, this became too generic a fix. I misunderstood your question yesterday; sorry.

You need to make it a bit more specific.

  1. The change should be applied only to those attributes that specify a length.
  2. Also the value of the attribute itself shouldn't change; only the use-site should be changed. That is, where the attribute gets interpreted as a length.

Ensuring 2 will automatically ensure 1.

And finally, all of this needs cross-checking with the specs and / or browser.

@atiqsayyed
Copy link
Contributor Author

@hrj not sure why the build is failing

@hrj
Copy link
Member

hrj commented Oct 26, 2015

There's some problem with the communication protocol. I restarted the build manually and it passed!

Can you rebase these changes onto master? Ping me on gitter if you need help with that.

@atiqsayyed atiqsayyed closed this Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

width="100px" doesn't work for img elements
2 participants