Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

width="100px" doesn't work for img elements #167

Closed
hrj opened this issue Sep 22, 2015 · 5 comments
Closed

width="100px" doesn't work for img elements #167

hrj opened this issue Sep 22, 2015 · 5 comments

Comments

@hrj
Copy link
Member

hrj commented Sep 22, 2015

This works:

<img src="..." width="100" />

But this doesn't

<img src="..." width="100px" />
@atiqsayyed
Copy link
Contributor

I'm picking this up. .

@hrj
Copy link
Member Author

hrj commented Oct 22, 2015

@atiqsayyed great! Let me know if the description is not sufficient in any issue. I sometimes just write the issue description in a hurry. Will come online after some time.

@atiqsayyed
Copy link
Contributor

@hrj By going through the code, i found that It can be the case with any attribute, not only just width. .
Should i do a generic fix?? (this can affect other elements as well)
Or should i fix it only for Image height and width.. which will solve the above issue?

@hrj
Copy link
Member Author

hrj commented Oct 22, 2015

@atiqsayyed Generic fix is better. You need to read the CSS specs to ensure that other elements are not adversely affected. (Fortunately we have the automated tests now, as a safety net). MDN is also a good resource.

@hrj
Copy link
Member Author

hrj commented Oct 22, 2015

@atiqsayyed If you find that the CSS spec is silent about something, we can follow the example of other browsers for that particular thing. The reference browser we have chosen is Firefox (because it tends to be more consistent).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants