Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimizedTNT entity behaviour #617

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

altrisi
Copy link
Collaborator

@altrisi altrisi commented Dec 7, 2020

Fixes #616

This is basically because in 1.16 snapshots the explosion code changed to not be eye height only for TNT.

I don't know if this fully fixes that or if it produces any other bug. I've just tested that it fixed visually (and in the end pos in the tnt logger) the specific case in the issue. I'm not an expert in explosion code. Please test.

@gnembon
Copy link
Owner

gnembon commented Dec 7, 2020

Very likely that's the problem. Optimized TNT code has this problem that is a rewrite, so small details like that will pass unnoticed.

Please @Fallen-Breath grab the proposed fix from https://github.com/gnembon/fabric-carpet/pull/617/checks (download artifacts) and confirm it works as in vanilla.

@Fallen-Breath
Copy link
Contributor

Fallen-Breath commented Dec 7, 2020

just finished a quick testing in the wdl in #616 and in my 360ftl heavy cannon in 1.16.4 with normal config and maximum firepower config and it worked well. tho i tested with other mods but i think this issue is solved

@altrisi
Copy link
Collaborator Author

altrisi commented Dec 7, 2020

Actually, I think the change was to fix TNT rendering in soulsand, and then this had to be added to prevent a bug that caused stacked TNT to jump, but yes, TNT jumping.

BTW just for relating: Relates to CaffeineMC/lithium#66. Else I wouldn't have known the reason for this.

@Fallen-Breath
Copy link
Contributor

Actually, I think the change was to fix TNT rendering in soulsand, and then this had to be added to prevent a bug that caused stacked TNT to jump.

BTW just for relating: Relates to jellysquid3/lithium-fabric#66. Else I wouldn't have known the reason for this.

ye that's why mojang did this change iirc

@gnembon gnembon merged commit bf9aa32 into gnembon:master Dec 7, 2020
@altrisi altrisi deleted the fix-explosions branch December 7, 2020 21:30
@altrisi altrisi restored the fix-explosions branch December 26, 2020 22:15
@altrisi altrisi deleted the fix-explosions branch December 26, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] optimizeTNT results in incorrect entity behavior
3 participants