Update testnet to 2.223.0 #1203

AdaJane · 2023-07-18T13:55:55Z

Description of proposed changes

Update Testnet to 2.223.0

Practical tips for PR review & merge:

All GitHub Actions report PASS
Newly added code/functions have unit tests
- Coverage tools report all newly added lines as covered
- The positive scenario is exercised
- Negative scenarios are exercised, e.g. assert on all possible errors
- Assert on events triggered if applicable
- Assert on changes made to storage if applicable
Modified behavior/functions - try to make sure above test items are covered
Integration tests are added if applicable/needed

Bumps [num_cpus](https://github.com/seanmonstar/num_cpus) from 1.15.0 to 1.16.0. - [Release notes](https://github.com/seanmonstar/num_cpus/releases) - [Changelog](https://github.com/seanmonstar/num_cpus/blob/master/CHANGELOG.md) - [Commits](seanmonstar/num_cpus@v1.15.0...v1.16.0) --- updated-dependencies: - dependency-name: num_cpus dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [eslint](https://github.com/eslint/eslint) from 8.43.0 to 8.44.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.43.0...v8.44.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [eslint](https://github.com/eslint/eslint) from 8.41.0 to 8.44.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.41.0...v8.44.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.59.5 to 5.60.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.60.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.59.2 to 5.60.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.60.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [eslint](https://github.com/eslint/eslint) from 8.41.0 to 8.44.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.41.0...v8.44.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.59.2 to 5.60.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.60.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [commander](https://github.com/tj/commander.js) from 10.0.1 to 11.0.0. - [Release notes](https://github.com/tj/commander.js/releases) - [Changelog](https://github.com/tj/commander.js/blob/master/CHANGELOG.md) - [Commits](tj/commander.js@v10.0.1...v11.0.0) --- updated-dependencies: - dependency-name: commander dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

Dependabot for example doesn't have access to secrets and this job will always fail.

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.59.5 to 5.60.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.60.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [eslint](https://github.com/eslint/eslint) from 8.41.0 to 8.44.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.41.0...v8.44.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: Alexander Todorov <[email protected]>

hardcoded initial authorities

- test with boundary values instead of random ones - test with a valid floating point argument

test with mixed-case argument instead of only lower case one

- test around boundary values - add tests with zero and a negative value

- add mixed case scenario - add scenario where input contains invalid hex chars

- more testing around boundary values

* maybe * need help for further progress * need help for further progress * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed minor issues * still not getting ti * pushing to github to test CI building of creditcoin-js * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * debugging * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * need to begin cleaning up for review * cleaned up code * cleaned up code and added comments * updated to use enum for ownership proof and added missing rust unit tests * addressed changes requested by review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * addressed rustfmt and linter issues * fixed more linter issues * fixed prettier issues with integration test * Fix benchmarks * Appease clippy * removed unnecessary --silent=false flag * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removed unnecessary --silent=false flag * Auto-update creditcoin-js type definitions * updated README.md to force rebuild * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Zachary Frederick <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nathan Whitaker <[email protected]> Co-authored-by: gluwa-bot <[email protected]>

we must make this CI check Required!

github-actions · 2023-07-18T14:37:36Z

For full LLVM coverage report click here!

atodorov

https://github.com/gluwa/creditcoin/actions/runs/5588358217/jobs/10215031254?pr=1203 is a false negative. MILLISECS_PER_BLOCK hasn't been modified in this PR but the grep script is probably tripping on itself.

codecov-commenter · 2023-07-18T14:43:46Z

Codecov Report

Merging #1203 (8354bbb) into testnet (7a6f5ca) will decrease coverage by 67.77%.
The diff coverage is 28.02%.

@@             Coverage Diff             @@
##           testnet   #1203       +/-   ##
===========================================
- Coverage    74.62%   6.85%   -67.77%     
===========================================
  Files           74      25       -49     
  Lines        10686     744     -9942     
  Branches         0      87       +87     
===========================================
- Hits          7974      51     -7923     
+ Misses        2712     693     -2019

Impacted Files	Coverage Δ
scripts/cc-cli/src/commands/balance.ts	`0.00% <0.00%> (ø)`
scripts/cc-cli/src/commands/bond.ts	`0.00% <0.00%> (ø)`
scripts/cc-cli/src/commands/distributeRewards.ts	`0.00% <0.00%> (ø)`
scripts/cc-cli/src/commands/newSeed.ts	`0.00% <0.00%> (ø)`
scripts/cc-cli/src/commands/send.ts	`0.00% <0.00%> (ø)`
scripts/cc-cli/src/commands/setKeys.ts	`0.00% <0.00%> (ø)`
scripts/cc-cli/src/commands/status.ts	`0.00% <0.00%> (ø)`
scripts/cc-cli/src/commands/unbond.ts	`0.00% <0.00%> (ø)`
scripts/cc-cli/src/commands/validate.ts	`0.00% <0.00%> (ø)`
scripts/cc-cli/src/commands/wizard.ts	`0.00% <0.00%> (ø)`
... and 4 more

... and 85 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

atodorov

I think https://github.com/gluwa/creditcoin/actions/runs/5588895423 will fail again b/c I've made some changes in #1127 which have not been merged to dev yet.

dependabot bot and others added 30 commits July 18, 2023 09:55

Only execute LLVM job if submitter has access to secret tokens

5a4895f

Dependabot for example doesn't have access to secrets and this job will always fail.

add: new parsing & tests

2083df7

add: handlers for required and defaulted options

2044637

add: implement new parsing in balance

e9b7a90

add: implement new parsing in bond

06801b4

add: implement new parsing in distribute-rewards

ebbd83f

add: improve new seed phrase length option parsing

bb8c63e

add: implement new parsing in send

8029171

add: improve parsing in set-keys

b652f97

add: swap checkAddress for parseAddress

c88d627

add: implement new parsing in unbond

90e4e97

add: implement new parsing in validate

9eb0bb9

add: implement new parsing in wizard

d86c39c

fix linter errors & warnings

f8ec5af

add: new workflow for creditcoin-cli

faddc12

rename text execution step

45451b6

Co-authored-by: Alexander Todorov <[email protected]>

fix: resolve pending conflict

bbea3b8

remove npx from test script

e8c57b6

move consensus switching into separate module

29b36ce

Grandpa import should always be active, with

320369b

hardcoded initial authorities

atodorov and others added 17 commits July 18, 2023 09:55

Upload cc-cli test coverage to CodeCov

a094e5e

Rename test scenarios for better readability

0361b9b

Update tests for parseAmount()

cb8f03c

- test with boundary values instead of random ones - test with a valid floating point argument

Update test for parseChoice()

3f21fb2

test with mixed-case argument instead of only lower case one

Update tests for parseInteger()

51c484b

- test around boundary values - add tests with zero and a negative value

Update tests for parseHexString()

362a8b4

- add mixed case scenario - add scenario where input contains invalid hex chars

Update tests for parsePercentAsPerbill()

2e81f86

- more testing around boundary values

fix: use regex for hexstring validation

6bf58dd

rename to AccountBalance

fbaae0c

fix: bond result logging

b394136

change balance fields & improve logging

3c8ef2f

add: use derive api & add unbonding

7e807dd

fix: linter error

7d10a1b

Add CI job to check for changes in EPOCH_DURATION

57f3fc0

we must make this CI check Required!

Add integration test to inspect the existing EPOCH_DURATION

8efe856

Add more tests to detect changes in block time and slot duration

a8c2a97

AdaJane requested review from pLabarta, atodorov, zacharyfrederick and nathanwhit July 18, 2023 13:56

atodorov reviewed Jul 18, 2023

View reviewed changes

Auto-update pallet weights

8354bbb

atodorov approved these changes Jul 18, 2023

View reviewed changes

pLabarta approved these changes Jul 18, 2023

View reviewed changes

nathanwhit approved these changes Jul 18, 2023

View reviewed changes

atodorov merged commit 1088daa into testnet Jul 19, 2023
38 of 41 checks passed

atodorov deleted the update-testnet-2.223.0 branch July 19, 2023 06:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update testnet to 2.223.0 #1203

Update testnet to 2.223.0 #1203

AdaJane commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

atodorov left a comment

codecov-commenter commented Jul 18, 2023

atodorov left a comment

Update testnet to 2.223.0 #1203

Update testnet to 2.223.0 #1203

Conversation

AdaJane commented Jul 18, 2023

Description of proposed changes

github-actions bot commented Jul 18, 2023

atodorov left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jul 18, 2023

Codecov Report

atodorov left a comment

Choose a reason for hiding this comment