Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-553: Sync-disconnect-and-upgrade test #1127

Merged
merged 12 commits into from
Jul 25, 2023
Merged

CSUB-553: Sync-disconnect-and-upgrade test #1127

merged 12 commits into from
Jul 25, 2023

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Jun 9, 2023

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov force-pushed the tests/CSUB-553-sync-disconnect-and-upgrade-test branch 4 times, most recently from 46fda9f to 4ec1c74 Compare June 9, 2023 19:49
@atodorov atodorov changed the base branch from testnet to main June 12, 2023 09:10
@atodorov atodorov force-pushed the tests/CSUB-553-sync-disconnect-and-upgrade-test branch from 4ec1c74 to 23fe393 Compare June 12, 2023 09:52
@atodorov atodorov marked this pull request as draft June 12, 2023 09:52
@atodorov atodorov force-pushed the tests/CSUB-553-sync-disconnect-and-upgrade-test branch 10 times, most recently from 3f2b216 to 0b97126 Compare June 13, 2023 12:28
@atodorov atodorov force-pushed the tests/CSUB-553-sync-disconnect-and-upgrade-test branch 6 times, most recently from 3814b9d to 92ab9b6 Compare June 19, 2023 17:57
atodorov added a commit that referenced this pull request Jun 28, 2023
@atodorov
Add a wait-for-sync.sh script to be used in CI job
74fb3b2 
from #1127
atodorov added a commit that referenced this pull request Jun 28, 2023
@atodorov
Add a wait-for-sync.sh script to be used in CI job
a2219fb 
from #1127
atodorov added a commit that referenced this pull request Jun 30, 2023
@atodorov
Add a wait-for-sync.sh script to be used in CI job
b00e8cd 
from #1127
@atodorov atodorov changed the base branch from main to testnet July 4, 2023 16:21
@atodorov atodorov force-pushed the tests/CSUB-553-sync-disconnect-and-upgrade-test branch 3 times, most recently from cded1f9 to 99fd8c5 Compare July 5, 2023 10:46
@atodorov atodorov force-pushed the tests/CSUB-553-sync-disconnect-and-upgrade-test branch 4 times, most recently from ef147fa to dfbd743 Compare July 17, 2023 15:20
@atodorov
Copy link
Contributor Author

Tests against the disconnected live node, synced from Testnet are passing here: https://github.com/gluwa/creditcoin/actions/runs/5578025040/jobs/10192016515

@atodorov
Copy link
Contributor Author

Rebasing & ready for review

@atodorov atodorov marked this pull request as ready for review July 17, 2023 17:53
@atodorov
ci: When running the forked network make sure to run as validator
55030ae 
b/c now we've switched Testnet to PoS and the local node running the
fork doesn't produce any blocks.
@atodorov
Live sync with Creditcoin network & test against disconnected node
775f83a 
- reorganize jobs tree to reuse the local blockchain DB as much as we can
- run local nodes before fork/try-runtime, etc to benefit from a shared
  sync
- shared script to install Docker engine from upstream
- kill hardhat-dev container b/c we're now running multiple jobs
  on a shared VM
@atodorov
Attempt switch-to-pos.test only if network is still PoW
deecf2d
@atodorov
Specify testnet config when testing against disconnected node
ab612aa
@atodorov
Specify a distinct port for disconnected test node
db2d1d9
@atodorov
Need to use LENDER_SEED / BORROWER_SEED for PoS Testnet too
12a9bd2
@atodorov
Replace hard-coded accounts Alice & Bob in integration tests
75316c8 
originally introduced in 5bb105a and
partially reverted in a5ef49d because
of the register-currency revert!
@atodorov
Specify LENDER_SEED & BORROWER_SEED for CI job
e8578da 
when testing against a disconnected Testnet node
@atodorov
Use createWallet() inside addAskAndBidOrder() instead of random wallets
a2d1243 
to avoid the situation where running this test first will register the
LENDER & BORROWER addresses with different wallets than the ones used
for testing (on Testnet/Mainnnet, which later results in problems)
@atodorov
Use tryRegisterAddress() inside addAskAndBidOrder()
ee7fe50 
otherwise we'll see failures when running tests against Testnet/Mainnet
@atodorov
LENDER_SEED and BORROWER_SEED variables need to be quoted
b3ea974
@atodorov atodorov force-pushed the tests/CSUB-553-sync-disconnect-and-upgrade-test branch from 9cc04da to 64281a2 Compare July 17, 2023 17:56
@atodorov atodorov changed the base branch from testnet to dev July 17, 2023 17:57
@atodorov atodorov force-pushed the tests/CSUB-553-sync-disconnect-and-upgrade-test branch from 64281a2 to e57ce7f Compare July 17, 2023 17:57
AdaJane pushed a commit that referenced this pull request Jul 18, 2023
@atodorov @AdaJane
Add a wait-for-sync.sh script to be used in CI job
45af349 
from #1127
@atodorov atodorov mentioned this pull request Jul 18, 2023
Merged
9 tasks
atodorov added a commit that referenced this pull request Jul 19, 2023
@atodorov
Add a wait-for-sync.sh script to be used in CI job
9d7614b 
from #1127
@pLabarta pLabarta self-requested a review July 19, 2023 12:55
@atodorov atodorov merged commit 5233290 into dev Jul 25, 2023
34 checks passed
@atodorov atodorov deleted the tests/CSUB-553-sync-disconnect-and-upgrade-test branch July 25, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pLabarta pLabarta pLabarta approved these changes

@AdaJane AdaJane AdaJane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atodorov @codecov-commenter @pLabarta @AdaJane