Mpcd Cosine and CosineExpansionContraction Channels #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Tzortzis's files to the branch Add new geometries to Cmakelists Add new geometries to StreamingGeometry.h and cc Change geometry filenames Add geometries to module.cc some fixes more changes in geometry files More fixes Fix compile errors Fix import errors Fix cuda compile errors Fix more compile errors Fix import errors Fix more import errors for GPU Fix typo Fix geometry names Fix gpu array error Add pytests Fix pytest out of box Fix tests fix comments Remove fillers Run pre-commit on geometry files
…c_sinusoidal_channel
…c_sinusoidal_channel
…c_sinusoidal_channel
…c_sinusoidal_channel
baho-cb
requested review from
a team,
joaander,
SchoeniPhlippsn and
rayasare
and removed request for
a team
mphoward
reviewed
Jul 9, 2024
…omd_sinusoidal_channel_fork into asymmetric_sinusoidal_channel
mphoward
requested changes
Jul 11, 2024
Co-authored-by: Michael Howard <[email protected]>
Co-authored-by: Michael Howard <[email protected]>
Co-authored-by: Michael Howard <[email protected]>
Co-authored-by: Michael Howard <[email protected]>
Co-authored-by: Michael Howard <[email protected]>
Co-authored-by: Michael Howard <[email protected]>
astatt
reviewed
Jul 19, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
github-actions
bot
added
the
stale
mphoward
approved these changes
Sep 6, 2024
|
Please merge the latest |
|
Oops, sorry about that! Should be taken care of. |
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new mpcd streaming geometries: Serpentine channel (CosineChannel) and sinusoidal expansion and contraction channel (CosineExpansionContraction).
This PR should be merged after the rejection filler PR (#1822).This PR has been merged.Motivation and context
Resolves #1775, #1776
How has this been tested?
Python tests are added for the geometries and streaming.
Change log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.