Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosine channel for MPCD #1776

Closed
tzortziskoul opened this issue May 6, 2024 · 3 comments
Closed

Add cosine channel for MPCD #1776

tzortziskoul opened this issue May 6, 2024 · 3 comments
Labels
enhancement New feature or request mpcd MPCD component

Comments

@tzortziskoul
Copy link
Contributor

tzortziskoul commented May 6, 2024

Description

We want to implement a second channel for mpcd streaming geometry in hoomd v4. It will be a symmetric wavy channel.

Proposed solution

The new geometry will be implemented as follows:

channel = hoomd.mpcd.geometry.CosineChannel(...)
hoomd.mpcd.stream.BounceBack(period=..., geometry=channel)

Additional context

We already have a plugin that implements some of the necessary infrastructure for hoomd v2, which we will port to hoomd v4. A similar issue has been opened for assymetric Contraction Expansion channel.

@tzortziskoul tzortziskoul added the enhancement New feature or request label May 6, 2024
@mphoward mphoward added the mpcd MPCD component label May 6, 2024
@mphoward mphoward changed the title Add cosine-wave channel for hoomd v4 Add cosine channel for MPCD May 6, 2024
@mphoward
Copy link
Collaborator

mphoward commented May 6, 2024

This issue is very similar to #1775 but the two cosines follow each other to make an S-shaped geometry. We will support implementing this feature too.

My only comment is that this geometry should be named CosineChannel according to our discussion, not CosineWavy.

@tzortziskoul
Copy link
Contributor Author

Yes, this is right, I just changed it to CosineChannel.

@mphoward
Copy link
Collaborator

Completed in #1836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mpcd MPCD component
Projects
None yet
Development

No branches or pull requests

2 participants