🩹 Fix ordering bug in MatrixProvider class #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1512 +/- ##
=======================================
- Coverage 88.6% 88.6% -0.1%
=======================================
Files 107 107
Lines 5128 5134 +6
Branches 962 965 +3
=======================================
+ Hits 4544 4549 +5
- Misses 468 469 +1
Partials 116 116 ☔ View full report in Codecov by Sentry. |
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
|
joernweissenborn
approved these changes
Aug 18, 2024
3 tasks
jsnel
added a commit
that referenced
this pull request
Aug 23, 2024
The `PFIDMegacomplex` is a megacomplex used for fitting perturbed free induction decay as described in Hamm 1995: https://doi.org/10.1016/0301-0104(95)00262-6 *👌 Guard against zero standard errors for fixed parameters *🧪👌 Add irf attribute to PFIDDatasetModel and update pfid unit tests - OneOscillationWithIrf - OneOscillationWithSequentialModel * ♻️Refactor pfid_megacomplex to be always index dependent * 📚 Added change to changelog * 🩹 Modify unit test to be more suspectiable to orderin bug (fixed in PR #1512 ) * 🧪 Added test to catch AttributeError validating bad pfid model definition * 🩹 Fix AttributeError validating bad pfid model definition * 🧰 Remove pre-commit from dev dependencies Co-authored-by: Sebastian Weigand <[email protected]> Co-authored-by: Jörn Weißenborn <[email protected]> Co-authored-by: Ivo van Stokkum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the call to combine_megacomplex_matrices the matrices would be reordered independent of their labels resulting in a combined matrix that would be ordered differently than expected. This issue was specifically found in the case of multiple types of different megacomplexes.
This bug fix was orginally part of #1510 but was seperated out because of its broader scope.
Change summary
Checklist