-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globalize:Provide Bidi structured text support to MessageFormat #539 #598
Conversation
to return results from translation table for translated attributes.
…anslated attributes in the query conditions.
…ess recursion, should fix problem reported in globalizejs#274.
This reverts commit 28653bb571052768158c84eaf98448e22e796df7.
…, from globalizejs#277." This reverts commit 6ad3de9.
Translated attributes as part of the join where
added a failing test case
Added uniq to with_translations to prevent duplicates when fallbacks are defined
Update CHANGELOG.md
Bug fix for saving changes in same translation
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
@rxaviers after contribution to SlexAxton/messageformat.js we are back to Globalize to finalize this task. Can you please review this submission ? I would also appreciate your guidance on CLA error we currently experience with this PR. Thanks a lot in advance. |
It looks like you've filed this against the wrong repository. Even if this is on purpose, its definitely very wrong in some other way. |
This commit looks fine: c48e22b - everything else doesn't belong here. Please create a new PR with only relevant commits. |
Hi @jzaefferer . I got somewhat confused, excuse me for ignorance. |
I see this creepy title |
It seems like you branched globalize/globalize instead of jquery/globalize (this repo), then added a commit on top. |
Thank you , yes, I confess doing this once upon a time on my master branch by mistake, so I would kindly ask your advice, should this pattern work for me?: |
Considering |
Thank you, I created new PR #599 instead of this one |
👍 |
As per discussion in #539 (comment)
this PR is based on corresponding feature been recently introduced in SlexAxton/messageFormatter.js
(see messageformat/messageformat#129)
It provides an ability to enforce Bidi structured text in message being formatted by using Unicode Bidi control characters. The upgrading qualities are: