-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #495
Update README.md #495
Conversation
Proposed in response to #494
@@ -214,6 +214,8 @@ requirements. See table below. | |||
| Plural module | cldr/supplemental/plurals.json (for cardinals)<br>cldr/supplemental/ordinals.json (for ordinals) | | |||
| Relative time module | cldr/main/`locale`/dateFields.json<br>+CLDR JSON files from number and plural modules | | |||
|
|||
As alternative to deducing this yourself you could try using a tool called [Globalize · So What'cha Want](http://johnnyreilly.github.io/globalize-so-what-cha-want/). This allows you to select the modules you're interested in using and tell you the Globalize files *and* CLDR JSON that you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tool allows you ... and tell_s_ you ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note a minor detail: double space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to @sompylasar and @rxaviers comments.
Also:
- Change "As alternative" to "As an alternative"
- Comma after "yourself"
- Change "you could try using" to "you could use"
So the first sentence would look like this:
As an alternative to deducing this yourself, you could use a tool called Globalize · So What'cha Want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kswedberg.
I'm also wondering if we can simplify the sentence... Something like this:
As an alternative to deducing the CLDR requirements yourself, use this [online tool][]. The tool allows you ... and tells you ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: simplify the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc content team, @kswedberg, @arthurvr, @agcolom. |
Changes based on feedback from team.
Thanks for the feedback folks - the changes have been made. |
👍 thanks for your contrib. |
My pleasure! |
Proposed in response to #494