Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #495

Closed
wants to merge 2 commits into from
Closed

Update README.md #495

wants to merge 2 commits into from

Conversation

johnnyreilly
Copy link
Contributor

Proposed in response to #494

Proposed in response to #494
@@ -214,6 +214,8 @@ requirements. See table below.
| Plural module | cldr/supplemental/plurals.json (for cardinals)<br>cldr/supplemental/ordinals.json (for ordinals) |
| Relative time module | cldr/main/`locale`/dateFields.json<br>+CLDR JSON files from number and plural modules |

As alternative to deducing this yourself you could try using a tool called [Globalize · So What'cha Want](http://johnnyreilly.github.io/globalize-so-what-cha-want/). This allows you to select the modules you're interested in using and tell you the Globalize files *and* CLDR JSON that you need.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tool allows you ... and tell_s_ you ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note a minor detail: double space.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to @sompylasar and @rxaviers comments.

Also:

  • Change "As alternative" to "As an alternative"
  • Comma after "yourself"
  • Change "you could try using" to "you could use"

So the first sentence would look like this:

As an alternative to deducing this yourself, you could use a tool called Globalize · So What'cha Want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kswedberg.

I'm also wondering if we can simplify the sentence... Something like this:

As an alternative to deducing the CLDR requirements yourself, use this [online tool][]. The tool allows you ... and tells you ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: simplify the link.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxaviers rxaviers added the docs label Aug 28, 2015
@rxaviers
Copy link
Member

/cc content team, @kswedberg, @arthurvr, @agcolom.

Changes based on feedback from team.
@johnnyreilly
Copy link
Contributor Author

Thanks for the feedback folks - the changes have been made.

@rxaviers
Copy link
Member

👍 thanks for your contrib.

@rxaviers rxaviers closed this in 1d3f98e Aug 29, 2015
@johnnyreilly
Copy link
Contributor Author

My pleasure!

ashensis pushed a commit to ashensis/globalize that referenced this pull request Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants