Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #495

Closed
wants to merge 2 commits into from
Closed

Update README.md #495

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad66ca2
Update README.md
johnnyreilly Aug 28, 2015
d2a9223
Update README.md
johnnyreilly Aug 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,8 @@ requirements. See table below.
| Plural module | cldr/supplemental/plurals.json (for cardinals)<br>cldr/supplemental/ordinals.json (for ordinals) |
| Relative time module | cldr/main/`locale`/dateFields.json<br>+CLDR JSON files from number and plural modules |

As alternative to deducing this yourself you could try using a tool called [Globalize · So What'cha Want](http://johnnyreilly.github.io/globalize-so-what-cha-want/). This allows you to select the modules you're interested in using and tell you the Globalize files *and* CLDR JSON that you need.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tool allows you ... and tell_s_ you ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note a minor detail: double space.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to @sompylasar and @rxaviers comments.

Also:

  • Change "As alternative" to "As an alternative"
  • Comma after "yourself"
  • Change "you could try using" to "you could use"

So the first sentence would look like this:

As an alternative to deducing this yourself, you could use a tool called Globalize · So What'cha Want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kswedberg.

I'm also wondering if we can simplify the sentence... Something like this:

As an alternative to deducing the CLDR requirements yourself, use this [online tool][]. The tool allows you ... and tells you ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: simplify the link.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


*(b) How am I supposed to get and load CLDR content?*

Learn [how to get and load CLDR content...](doc/cldr.md).
Expand Down