Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a mock element instead of -1 #192

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Provide a mock element instead of -1 #192

merged 1 commit into from
Jan 22, 2020

Conversation

reakaleek
Copy link
Collaborator

Closes #185

@reakaleek
Provide a mock element instead of -1 to avoid errors, when CountUp.js…
2ef9a5a 
… is trying to set innerHTML under some circumstances
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.519% when pulling 2ef9a5a on mock-element into 36c6f0d on master.

@mmarkelov
Copy link
Collaborator

@reakaleek thanks!

@glennreyes
Copy link
Owner

glennreyes commented Oct 9, 2019 •
edited
Loading

@RobinBressan can you confirm this fixes the problem? Thanks!

@RobinBressan
Copy link

@reakaleek @glennreyes I test this asap! Thanks!

@mmarkelov mmarkelov merged commit d6e89f7 into master Jan 22, 2020
@mmarkelov mmarkelov deleted the mock-element branch July 12, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmarkelov mmarkelov mmarkelov approved these changes

@glennreyes glennreyes glennreyes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using -1 as target element in useCountUp breaks in test
5 participants
@reakaleek @coveralls @mmarkelov @glennreyes @RobinBressan