Using -1 as target element in useCountUp breaks in test

[RobinBressan]

Hi,

I'm trying to have storyshot running and my components using react-countup are breaking tests because countup.js try to set innerHTML on -1.

Maybe you should pass an empty litteral object in here:

react-countup/src/useCountUp.js

Line 7 in 718eb2c

const NO_ELEMENT = -1;

But not sure why this is triggering an error only in tests, it seems triggered inside react-test-renderer.

Do you have some feedback on this?

Thank you very much for your time and work!

[mmarkelov]

@RobinBressan I can take a look, but it will be helpful if you could provide your code, that breaking tests

[glennreyes]

Maybe @reakaleek has an idea how to solve this? As far as I can remember can this be any truthy value that is not an actual element.

[reakaleek]

Yeah, the -1 thing is obviously a hack. It was meant to avoid creating an element with document.createElement every time.
But we could actually create an element like once and just pass the same instance every time to fix this

or actually just pass { innerHTML: null }