Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override min_size via command-line argument #114

Merged
merged 8 commits into from
Dec 22, 2021
Merged

Allow to override min_size via command-line argument #114

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6079e40
Allow to override min_size via command-line argument
sbesson Aug 19, 2021
46aaa86
Fix checkstyle errors
sbesson Aug 20, 2021
a898914
Use more exact shape asserts
sbesson Aug 21, 2021
886f1ee
Add a second min-size test where the sizes do not exactly match
sbesson Aug 21, 2021
280471e
Fix checkStyleTest
sbesson Aug 21, 2021
eb6656a
Add test covering the asymmetric XY scenario
sbesson Aug 21, 2021
75b2863
Replace --min-size as --target-min-size
sbesson Aug 24, 2021
ba4bc15
Merge remote-tracking branch 'origin/master' into min_size
chris-allan Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/test/java/com/glencoesoftware/bioformats2raw/test/ZarrTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,11 +1222,11 @@ public void testMinSizeOption() throws Exception {
List<Map<String, Object>> datasets =
(List<Map<String, Object>>) multiscale.get("datasets");

String last_path = (String) datasets.get(datasets.size() - 1).get("path");
ZarrArray last_array = z.openArray(last_path);
String lastPath = (String) datasets.get(datasets.size() - 1).get("path");
ZarrArray lastArray = z.openArray(lastPath);

assert last_array.getShape()[0] < 32;
assert last_array.getShape()[1] < 32;
assert lastArray.getShape()[0] < 32;
assert lastArray.getShape()[1] < 32;
sbesson marked this conversation as resolved.
Show resolved Hide resolved
}

private void checkPlateGroupLayout(Path root, int rowCount, int colCount,
Expand Down