-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to override min_size via command-line argument #114
Conversation
The current implementation stops downsampling the image as soon as both X and Y dimensions are smaller than 256. In some cases, we want this cut-off values to be configurable. This commit makes the minimal change by keeping the default as 256 but allowing to override it via command-line option.
src/test/java/com/glencoesoftware/bioformats2raw/test/ZarrTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 tests look much nicer now, thanks.
I do wonder though if the --min-size 30
tests expose undesired behavior; an 8x16 image doesn't match with the Minimum size of the largest XY dimension
being 30. That isn't an issue introduced in this PR, so I'm happy for this to be merged and we can discuss the correct behavior separately.
Heh. I was hesitant to start this conversation but since you brought it up, I am also not convinced by the If we were to agree on the thumbnail nomenclature, I would propose something along the lines of |
I'm fine with |
My inclination is to call this |
75b2863 conceptually looks great to me. Will defer to @melissalinkert for anything else here. |
Looks good to me too, thanks! |
The current implementation stops downsampling the image as soon as both X and Y dimensions are smaller than 256. In some cases, we want this cut-off values to be configurable.
This commit makes the minimal change by keeping the default as 256 but allowing to override it via command-line option.
Tests are also added to cover the min-size arguments with various scenarios