add DeepL Pro artificial intelligence translation service #294

neumayr · 2018-07-30T10:09:46Z

Hey @glebm 👋

add DeepL Pro artificial intelligence translation service ✨
- DeepL trains artificial intelligence to understand and translate texts.
- 🇬🇧 🇺🇸 🇩🇪 🇫🇷 🇪🇸 🇮🇹 🇳🇱 🇵🇱
- TechCrunch: DeepL schools other online translators with clever machine learning
use deepl-rb gem for query the API 💎
- Kudos to @wikiti for helping with the latest v2.1.0 release that adds ignore_tags 💪

Update August 2018

DeepL is working to add the translation for 🇵🇹 🇷🇺 🇯🇵 🇨🇳 but didn't specify a fixed release date yet

glebm · 2018-07-30T17:44:53Z

lib/i18n/tasks/deepl_translation.rb

+    # @return [Array<[String, Object]>] translated list
+    def fetch_translations(list, opts)
+      options = {
+        tag_handling: 'xml',


Should it have tag_handling: 'xml' for non-HTML keys?

glebm · 2018-07-30T17:47:49Z

README.md

+```yaml
+# config/i18n-tasks.yml
+translation:
+  api_key: <Deep Pro API key>


Let's have separate settings for different API keys. google_translate_api_key and deepl_api_key. (api_key can then work as google_translate_api_key with a deprecation warning`)

glebm · 2018-07-30T17:48:45Z

lib/i18n/tasks/command/commands/missing.rb

@@ -46,6 +47,20 @@ def translate_missing(opt = {})
          print_forest translated, opt
        end

+        # DeepL Pro Translate
+        cmd :translate_missing_deepl,


Let's add a --backend flag to translate_missing instead of having a separate command that is otherwise identical.

The argument definition can look something like this:

TRANSLATION_BACKENDS = %w[google deepl].freeze DEFAULT_TRANSLATION_BACKEND = TRANSLATION_BACKENDS[0] arg :translation_backend, '-b', '--backend BACKEND', TRANSLATION_BACKENDS, t('i18n_tasks.cmd.args.desc.translation_backend', valid_text: TRANSLATION_BACKENDS * ', ', default_text: DEFAULT_TRANSLATION_BACKEND), parser: OptionParsers::Enum::Parser.new( values, ->(value, valid) { I18n.t('i18n_tasks.cmd.errors.invalid_format', invalid: value, valid: TRANSLATION_BACKENDS * ', ')})

Could you check if Command::Options::Locales could be good as well?

glebm · 2018-07-30T17:50:03Z

lib/i18n/tasks/deepl_translation.rb

+
+    # @param [Array<[String, Object]>] list of key-value pairs
+    # @return [Array<[String, Object]>] translated list
+    def translate_list(list, opts) # rubocop:disable Metrics/AbcSize


Consider prefixing all methods here and in google_translation.rb with google_ / deepl_ and extracting common methods into a base_translation.rb module.

Alternatively, extract all the logic from fetch_translations and below to a class to avoid namespace conflicts. A base class with two descendants is also OK.

I prefixed the methods with google_ / deepl_. The only method is *_to_values(list) that would identify for a base_translation.rb Do you think it's worth sharing?

Not worth it unless we re-structure it to share more methods. I can look into it after merging, thanks.

glebm · 2018-07-30T18:01:46Z

Thanks @neumayr, I've left some comments.

* add [DeepL Pro](https://www.deepl.com/pro) artificial intelligence translation service * use [`deepl-rb`](https://github.com/wikiti/deepl-rb) gem for query the API * currently the cmd is `i18n-tasks translate-missing-deepl` because I wasn’t sure how you would structure the commands with multiple vendors

* separate translation settings into different API keys * `google_translate_api_key` * `deepl_api_key`

* add `—backend` flag to `translate_missing` command

* prefix google methods with `google_`

neumayr · 2018-07-31T14:34:49Z

@glebm Ready for another review round

* run `i18n-tasks normalize`

glebm · 2018-08-01T08:03:39Z

lib/i18n/tasks/deepl_translation.rb

+    # @return [Array<[String, Object]>] translated list
+    def fetch_translations(list, opts)
+      options = {
+        ignore_tags: %w[i18n]


Does ignore_tags work even without tag_handling: 'xml'?
If not, we may need to use the same trick as in the Google Translate implementation

Yes, ignore_tags works even without other params. And should be fixed,
because %{user} interpolation can be with _html / .html keys and inside simple text tags too.

📝 https://www.deepl.com/api.html

glebm · 2018-08-01T18:09:46Z

Thanks, merged! Can you email me the key so I may add it to Travis?

Adds prefixes to stragglers. Changelog.

Follow-up to #294

glebm · 2018-08-01T19:03:04Z

I've moved the shared code to a base class in 0002e80

Follow-up to #294

neumayr force-pushed the deepl-translation branch from 4ae1429 to b31b573 Compare July 30, 2018 10:31

glebm reviewed Jul 30, 2018

View reviewed changes

neumayr added 5 commits July 31, 2018 16:31

separate translation settings into different API keys

fd9d7d1

* separate translation settings into different API keys * `google_translate_api_key` * `deepl_api_key`

add backend flag to translate_missing

9553c4d

* add `—backend` flag to `translate_missing` command

prefix google methods with google

979f008

* prefix google methods with `google_`

remove fixed tag_handling

0bdbaa1

neumayr force-pushed the deepl-translation branch from 57aefc7 to 0bdbaa1 Compare July 31, 2018 14:32

fix rubocop

ef59d2a

run i18n-tasks normalize

d52e1b2

* run `i18n-tasks normalize`

glebm reviewed Aug 1, 2018

View reviewed changes

glebm merged commit 46fb95c into glebm:master Aug 1, 2018

glebm deleted the deepl-translation branch August 1, 2018 18:09

glebm added a commit that referenced this pull request Aug 1, 2018

Follow-up on #294

73270d3

Adds prefixes to stragglers. Changelog.

glebm added a commit that referenced this pull request Aug 1, 2018

Introduce a base class for translation impls

d82679d

Follow-up to #294

glebm added a commit that referenced this pull request Aug 1, 2018

Introduce a base class for translation impls

ad33180

Follow-up to #294

glebm added a commit that referenced this pull request Aug 1, 2018

Introduce a base class for translation impls

cdd1fc9

Follow-up to #294

glebm added a commit that referenced this pull request Aug 1, 2018

Introduce a base class for translation impls

0002e80

Follow-up to #294

glebm added a commit that referenced this pull request Aug 3, 2018

DeepL fixes

00aa0ec

Follow-up to #294

dgilperez mentioned this pull request Aug 20, 2018

Make new deepl dependency optional #296

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add DeepL Pro artificial intelligence translation service #294

add DeepL Pro artificial intelligence translation service #294

neumayr commented Jul 30, 2018 •

edited

Loading

glebm Jul 30, 2018

neumayr Jul 31, 2018

glebm Jul 30, 2018

glebm Jul 30, 2018 •

edited

Loading

neumayr Jul 31, 2018

glebm Jul 30, 2018 •

edited

Loading

neumayr Jul 31, 2018

glebm Aug 1, 2018

glebm commented Jul 30, 2018

neumayr commented Jul 31, 2018

glebm Aug 1, 2018

neumayr Aug 1, 2018 •

edited

Loading

glebm commented Aug 1, 2018

glebm commented Aug 1, 2018 •

edited

Loading

add DeepL Pro artificial intelligence translation service #294

add DeepL Pro artificial intelligence translation service #294

Conversation

neumayr commented Jul 30, 2018 • edited Loading

Update August 2018

glebm Jul 30, 2018

Choose a reason for hiding this comment

neumayr Jul 31, 2018

Choose a reason for hiding this comment

glebm Jul 30, 2018

Choose a reason for hiding this comment

glebm Jul 30, 2018 • edited Loading

Choose a reason for hiding this comment

neumayr Jul 31, 2018

Choose a reason for hiding this comment

glebm Jul 30, 2018 • edited Loading

Choose a reason for hiding this comment

neumayr Jul 31, 2018

Choose a reason for hiding this comment

glebm Aug 1, 2018

Choose a reason for hiding this comment

glebm commented Jul 30, 2018

neumayr commented Jul 31, 2018

glebm Aug 1, 2018

Choose a reason for hiding this comment

neumayr Aug 1, 2018 • edited Loading

Choose a reason for hiding this comment

glebm commented Aug 1, 2018

glebm commented Aug 1, 2018 • edited Loading

neumayr commented Jul 30, 2018 •

edited

Loading

glebm Jul 30, 2018 •

edited

Loading

glebm Jul 30, 2018 •

edited

Loading

neumayr Aug 1, 2018 •

edited

Loading

glebm commented Aug 1, 2018 •

edited

Loading