Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new deepl dependency optional #296

Closed
dgilperez opened this issue Aug 20, 2018 · 2 comments
Closed

Make new deepl dependency optional #296

dgilperez opened this issue Aug 20, 2018 · 2 comments

Comments

@dgilperez
Copy link

Hi!

After upgrading the gem, I just noticed the new dependency on deepl on our project added by #294.

While this service looks great, I'd like to suggest to implement it as an optional dependency somehow - adding this gem to any project using i18n-tasks, regardless of they use Deepl or not (most won't).

Probably this will involve removing de dependency from the gemspec and adding a note to README, with the need to add gem 'deepl' to the Gemfile, right?

Would you accept a PR?

@glebm glebm closed this as completed in d94aa85 Aug 20, 2018
@glebm
Copy link
Owner

glebm commented Aug 20, 2018

Dependency made optional in v0.9.24

@dgilperez
Copy link
Author

Thanks! That was faaast! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants