Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit.ci #234

Closed
Saransh-cpp opened this issue Sep 18, 2024 · 0 comments · Fixed by #245
Closed

Add pre-commit.ci #234

Saransh-cpp opened this issue Sep 18, 2024 · 0 comments · Fixed by #245
Assignees
@Saransh-cpp
Labels
infrastructure Project infrastructure: dev tools, packaging, etc.

Comments

@Saransh-cpp
Copy link
Member

Saransh-cpp commented Sep 18, 2024 •
edited
Loading

Is Your Feature Request Related to a Problem? Please Describe

Related to #170

I find the pre-commit.ci bot really helpful on public repositories. The bot can make formatting fixes and create occasional PRs to update the version of pre-commit hooks. We can then also have a pre-commit badge in README to show that the repository follows good practices. The addition is quite opinionated tho. Some repositories that I work on prefer not having it; hence, open for discussion.

Describe the Solution You'd Like

No response

Describe Alternatives You've Considered

No response

Additional Context

No response
@Saransh-cpp Saransh-cpp added the infrastructure Project infrastructure: dev tools, packaging, etc. label Sep 18, 2024
@Saransh-cpp Saransh-cpp self-assigned this Sep 18, 2024
Saransh-cpp added a commit that referenced this issue Sep 18, 2024
@Saransh-cpp
gh-234: add pre-commit.ci support
d1e30a2
@Saransh-cpp Saransh-cpp mentioned this issue Sep 18, 2024
Merged
Saransh-cpp added a commit that referenced this issue Sep 18, 2024
@Saransh-cpp
gh-234: add pre-commit.ci support
cdbb46f
paddyroddy pushed a commit that referenced this issue Sep 18, 2024
@Saransh-cpp @pre-commit-ci
gh-234: add pre-commit.ci support (#245)
2c4a712 
I have already enable `pre-commit.ci` in the repository settings. This
just adds a pretty PR title layer over the bot.

Closes: #234
Refs: #187

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Saransh-cpp Saransh-cpp

Labels
infrastructure Project infrastructure: dev tools, packaging, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-234: add pre-commit.ci support glass-dev/glass
1 participant
@Saransh-cpp