Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit setup #170

Closed
ntessore opened this issue Sep 6, 2024 · 2 comments
Closed

Update pre-commit setup #170

ntessore opened this issue Sep 6, 2024 · 2 comments
Assignees
@paddyroddy @Saransh-cpp
Labels
infrastructure Project infrastructure: dev tools, packaging, etc.
Milestone
v2024.2

Comments

@ntessore
Copy link
Collaborator

ntessore commented Sep 6, 2024

Use a modern pre-commit setup with ruff etc.
@ntessore ntessore added the infrastructure Project infrastructure: dev tools, packaging, etc. label Sep 6, 2024
@ntessore ntessore added this to the next milestone Sep 6, 2024
@ntessore ntessore self-assigned this Sep 6, 2024
@paddyroddy paddyroddy assigned paddyroddy and unassigned ntessore Sep 10, 2024
@paddyroddy
Copy link
Member

Related to this, should remove flake8 as it's fallen out of favour (partly due to the maintainer)

@paddyroddy paddyroddy mentioned this issue Sep 17, 2024
Merged
@Saransh-cpp Saransh-cpp mentioned this issue Sep 18, 2024
Closed
Saransh-cpp added a commit that referenced this issue Sep 18, 2024
@Saransh-cpp
gh-170: add traditional pre-commit-hooks
e3f8cfa
@Saransh-cpp Saransh-cpp mentioned this issue Sep 18, 2024
Merged
Saransh-cpp added a commit that referenced this issue Sep 18, 2024
@Saransh-cpp
gh-170: add traditional pygrep hooks
954b874
@Saransh-cpp Saransh-cpp mentioned this issue Sep 18, 2024
Merged
@Saransh-cpp Saransh-cpp self-assigned this Sep 18, 2024
Saransh-cpp added a commit that referenced this issue Sep 18, 2024
@Saransh-cpp
gh-170: add traditional pygrep hooks (#236)
a101ab4 
Adds several misc `pygrep` hooks recommended by scientific python.

Refs: #170, #187
paddyroddy added a commit that referenced this issue Sep 18, 2024
@Saransh-cpp @paddyroddy
gh-170: add traditional pre-commit-hooks (#235)
f7cedc9 
Adds several misc `pre-commit-hooks` recommended by scientific python.

Refs: #170, #187

---------

Co-authored-by: Patrick J. Roddy <[email protected]>
@Saransh-cpp Saransh-cpp mentioned this issue Sep 19, 2024
Merged
Saransh-cpp added a commit that referenced this issue Sep 19, 2024
@Saransh-cpp
gh-170: add scientific python recommended blacken-docs
7a018e3
@Saransh-cpp Saransh-cpp mentioned this issue Sep 19, 2024
Merged
Saransh-cpp added a commit that referenced this issue Sep 19, 2024
@paddyroddy @pre-commit-ci
@ntessore @Saransh-cpp
gh-231: add ruff linting to pre-commit (#232)
e58d861 
Add `ruff` linting and turn on as many rules as possible. However, I
will turn off many and not spend too much time fixing them. In a perfect
world, we will try and fix as many of these as possible - as they will
generally help with maintenance in the long term.

Closes: #231
Refs: #170
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nicolas Tessore <[email protected]>
Co-authored-by: Saransh Chopra <[email protected]>
Saransh-cpp added a commit that referenced this issue Sep 19, 2024
@Saransh-cpp
gh-170: add scientific python recommended blacken-docs
779f36f
Saransh-cpp added a commit that referenced this issue Sep 23, 2024
@paddyroddy @Saransh-cpp
gh-170: add yamllint and run over the repo (#230)
46bbd92 
Add `yamllint` as a pre-commit hook and format all
the YAML files in the repository.

Refs: #170
Co-authored-by: Saransh Chopra <[email protected]>
paddyroddy added a commit that referenced this issue Sep 25, 2024
@Saransh-cpp @paddyroddy
gh-170: add scientific python recommended blacken-docs (#250)
2d6e21b 
Add blacken-docs for formatting of documentation files.

Refs: #170, #187

---------

Co-authored-by: Patrick J. Roddy <[email protected]>
@Saransh-cpp
Copy link
Member

All Scientific Python recommended (and a few extras as well) pre-commit hooks have been added. The only major one missing is mypy, but that is being tracked in #280. Closing this as completed!

Saransh-cpp added a commit that referenced this issue Sep 25, 2024
@Saransh-cpp @paddyroddy
gh-170: add scientific python recommended blacken-docs (#250)
7ccf9a1 
Add blacken-docs for formatting of documentation files.

Refs: #170, #187

---------

Co-authored-by: Patrick J. Roddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

@Saransh-cpp Saransh-cpp

Labels
infrastructure Project infrastructure: dev tools, packaging, etc.
Projects
None yet
Milestone
v2024.2
Development

No branches or pull requests
3 participants
@ntessore @paddyroddy @Saransh-cpp