Reform operator spread #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, unary operator spreading happened implicitly, leading to surprises like typeof [] != typeof [0] (== [typeof 0]). With this commit, a splat is required prior to the array being spread over: typeof ...[0] == [typeof 0]. Implicit operator spreading is no longer handled; typeof [0] is just typeof [0].
This enables ...[a, b] += 1 to have the same meaning as ++..[a, b].
|
That looks good! It might take me a few days before I can actually review it though. I might also want to add a few more tests. It's a pretty big change. When merged, I'll also create an issue to track the docs state about this. |
|
I like the DRY aspect of this. And I can't think of any way this could currently conflict with standard argument spreading. And +1 for making odd edge cases explicit errors. |
|
Seems like no one objected, so I'm just gonna merge it :). Thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per conversation in #831, these commits make breaking changes to operator spreading.
typeof ...[0]=>[typeof 0]typeof ...{a: 0}=>{a: typeof 0}++...a{b, c}can be written as...a{b, c} += 1foo ...+...a<[b c]>=>foo.apply(null, [+a['b'], +a['c']])works.(...a=b) ->never really worked (an array, even empty, will never be nullish) but is now an explicit error.Close #831