Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unary spread delete stopped working in 1.5.0 #891

Closed
smokku opened this issue May 16, 2016 · 7 comments
Closed

Unary spread delete stopped working in 1.5.0 #891

smokku opened this issue May 16, 2016 · 7 comments

Comments

@smokku
Copy link

smokku commented May 16, 2016

What is documented in 1.4.0

Unary spread - when the operand is a list literal, apply the unary op to each item:
...
delete list[1, 2, 3]

compiles and works fine in 1.4.0:

$ echo 'delete list[1, 2, 3]' | node_modules/livescript/bin/lsc -scbp
// Generated by LiveScript 1.4.0
delete list[1], delete list[2], delete list[3];

but fails in 1.5.0:

$ echo 'delete list[1, 2, 3]' | node_modules/livescript-loader/node_modules/livescript/bin/lsc -scbp
[SyntaxError: invalid delete on line 1]
@vendethiel
Copy link
Contributor

Syntax changed. @gkz released a bit fast, I think.

@gkz
Copy link
Owner

gkz commented May 16, 2016

We don't have tests for this? Odd. I wonder what changed between versions

@rhendric
Copy link
Collaborator

#863 is what changed. See also #866.

@vendethiel
Copy link
Contributor

@gkz uhm, as my message said, the syntax changed - forgot to create an issue WRT docs.

@gkz
Copy link
Owner

gkz commented May 17, 2016

Ah ok cool, didn't see that change

@summivox
Copy link
Contributor

Many changes post-1.4.0 were intended for 2.0.0 (i.e. breaking).
IMHO 1.5.0 should be deprecated on NPM... People not pinning version are bound to get in trouble.

@vendethiel
Copy link
Contributor

btw that's #866.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants