Biometrics fixes EU/US

[MaikelStuivenberg]

Summary by CodeRabbit

• New Features

  • Enhanced login process with detailed user feedback and error handling.
  • Updated logout functionality with an optional full reset feature.
  • Improved authentication checks for user registration status.

• Bug Fixes

  • Refined loading state management during email signup processes.

• Documentation

  • Updated method signatures for clarity and consistency.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the authentication logic within the AuthCubit, enhancing the login and logout functionalities. Changes include updates to method signatures and the addition of new parameters, improved error handling, and refined checks for user authentication status. The EmailSignupPage class also sees adjustments in its authentication checks and control flow, ensuring proper handling of user registration and navigation. The logout behavior in the logout_helper is updated to perform a full reset. Overall, these changes aim to improve state management and user feedback during authentication processes.

Changes

File	Change Summary
lib/features/auth/cubit/auth_cubit.dart	- Updated login method to emit userExt upon authentication. - Modified logout method signature to accept optional fullReset parameter. - Enhanced checkAuth to emit userExt with unauthenticated status. - Improved error handling in login for specific cases. - Clarified biometric check logic.
lib/features/email_signup/presentation/pages/email_signup_page.dart	- Altered _checkAuthentication method to include additional registration checks. - Added missing break in handleCustom method to prevent fall-through. - Retained BlocListener for AuthCubit to manage navigation based on login status.
lib/features/family/helpers/logout_helper.dart	- Updated logout function to call logout(fullReset: true) in AuthCubit, changing logout behavior.

Possibly related PRs

• Bug: fix intruder john and registration break off (KIDS-1324) #1068: Modifications in AuthCubit regarding the refreshUser method, focusing on user authentication and state management.
• Bug: fix registration being mega buggy #1129: Simplification of the refreshUser method in AuthCubit, aligning with the main PR's enhancements.
• Feature: family auth cubit (KIDS-1594) #1202: Introduction of FamilyAuthCubit, relevant to the authentication logic central to the main PR's changes.
• Feature: Auth cubit part 2 of 3 #1209: Continued enhancements to FamilyAuthCubit, directly related to the main PR's focus on authentication handling.
• solve pushnotification and startup loading errors (KIDS-1679) #1248: Modifications to AuthCubit and its error handling, aligning with the main PR's focus on enhancing the authentication process.
• Bug: Fix setup biometrics screens not showing up in registration anymore (KIDS-1668) #1250: Updates to the EmailSignupPage that improve navigation and error handling during the registration process, related to the main PR's focus on enhancing the authentication flow.
• Show biometrics eu startup #1251: Addition of biometric authentication checks in the EmailSignupPage, related to the main PR's focus on user authentication flows.

Suggested labels

enhancement

Suggested reviewers

• TammiLion
• Daniela510

🐰 In the land of code, where bunnies hop,
Changes to auth make the login pop!
With states refined and errors caught,
A smoother path is what we've sought.
So let's leap ahead, with joy and cheer,
For better flows are finally here! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.