Bug: fix intruder john and registration break off (KIDS-1324)

[TammiLion]

Fixes:

• intruder john
• breaking off registration means you got stuck and could never progress again and also not logout

Summary by CodeRabbit

• New Features

  • Enhanced user authentication management with the ability to force session updates.
  • Improved user registration flow by directing users to complete necessary steps based on their registration status.

• Bug Fixes

  • Added error handling during authentication to prevent application crashes.

• Documentation

  • Updated logic in the profile selection screen to improve user experience during registration.

• Chores

  • Refined method calls to ensure authentication updates are handled more effectively.
  • Adjusted navigation behavior on registration success and sign-up pages to prevent back navigation.

[coderabbitai]

Walkthrough

The pull request introduces modifications primarily focused on enhancing user authentication and session management. Key changes include the addition of a forceAuthUpdate parameter in the refreshUser method of the AuthCubit class, allowing for conditional updates to the authentication session stream. The updateSessionStream method in the AuthRepository has also been updated to accommodate this new parameter. Furthermore, error handling has been improved in the ProfilesCubit, and logic for user registration has been refined in the ProfileSelectionScreen.

Changes

File Path	Change Summary
lib/features/auth/cubit/auth_cubit.dart	Modified refreshUser method to include forceAuthUpdate parameter, enhancing control over authentication session updates.
lib/features/auth/repositories/auth_repository.dart	Updated updateSessionStream method to accept an optional force parameter, allowing session updates regardless of current state.
lib/features/family/features/profiles/cubit/profiles_cubit.dart	Introduced error handling via a try-catch block around authentication logic, improving robustness.
lib/features/family/features/profiles/screens/profile_selection_screen.dart	Added logic to handle ProfilesNeedsRegistration state, enabling navigation to the credit card details page when necessary.
lib/features/registration/bloc/registration_bloc.dart	Modified authCubit.refreshUser() call to include forceAuthUpdate: true, ensuring explicit authentication updates during user data refresh.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AuthCubit
    participant AuthRepository
    participant ProfilesCubit
    participant ProfileSelectionScreen

    User->>AuthCubit: refreshUser(emitAuthentication, forceAuthUpdate)
    AuthCubit->>AuthRepository: updateSessionStream(hasSession, force)
    AuthRepository->>AuthCubit: session updated
    AuthCubit->>ProfilesCubit: emit new state
    ProfilesCubit->>ProfileSelectionScreen: check registration state
    ProfileSelectionScreen->>User: navigate to credit card details if needed

Loading

Assessment against linked issues

Objective	Addressed	Explanation
To not see the profile pick screen with 'John' (KIDS-1324)	❓	The changes do not explicitly address the visibility of the profile screen after registration.

Possibly related PRs

• New Summary Screen Reflect & Share (KIDS-1395) #1061: Changes in the RegistrationBloc class to call authCubit.refreshUser(forceAuthUpdate: true) are related to the modifications in the user authentication flow and session updates.

Suggested labels

enhancement

Poem

🐰 In the meadow where bunnies play,
Changes hop in, brightening the day.
With a flick of a tail, updates take flight,
Authentication flows, everything feels right!
Error handling's here, no more fright,
For every user, the path is now bright! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

lib/features/registration/pages/us_signup_page.dart (1)

81-81: Preventing back navigation during sign-up.

Setting canPop to false prevents users from navigating back during the sign-up process, which can help guide them to complete registration. However, please consider the potential impact on user experience, as some users may want to review or modify information on previous screens.

Consider providing an alternative way for users to review or edit their information before finalizing registration, such as a summary screen or an edit button.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f692bf3 and 581fade.

Files selected for processing (2)

• lib/features/registration/pages/registration_success_us.dart (1 hunks)
• lib/features/registration/pages/us_signup_page.dart (1 hunks)

Additional comments not posted (1)

lib/features/registration/pages/registration_success_us.dart (1)

20-45: Excellent work on improving the user experience!

The removal of the PopScope widget and the addition of canPop: false in the FunScaffold effectively prevent users from accidentally navigating back and getting stuck in the registration flow. This change aligns perfectly with the PR objective of fixing the issue where users could encounter obstacles during the registration process.

By guiding users forward to the next step of setting up their family, you have ensured a smoother and more intuitive user experience. Great job!