Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/kristofer_221103 #657

Merged
merged 11 commits into from
Nov 7, 2022
Merged

Fix/kristofer_221103 #657

merged 11 commits into from
Nov 7, 2022

Conversation

kristoferlund
Copy link
Member

@kristoferlund kristoferlund commented Nov 3, 2022 •
edited
Loading

Fixes some small issues:

  • Increases the number of quantifier assignment attempts from 3 to 5. Note that under some circumstances the algorithm cannot assign quantifiers and uphold the rules defined in the settings. The solution is then to change the assignment parameterd, for example by adding an additional quantifier.
  • Headers in exported csv files are now lowercase
  • Fixed typos in quantification settings descriptions
  • Moved settings checkbox to be inline with description instead of under it.
  • Period page should list number of praise in the period

Closes #644
Closes #645
Closes #653
Closes #636
Closes #639
Closes #635
Closes #651

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
10.5% 10.5% Duplication

@kristoferlund kristoferlund merged commit faa1ad9 into main Nov 7, 2022
@kristoferlund kristoferlund deleted the fix/kristofer_221103 branch November 7, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kristoferlund