Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an error when someone tries to upload invalid logos #636

Closed
Vyvy-vi opened this issue Oct 18, 2022 · 0 comments · Fixed by #657
Closed

Raise an error when someone tries to upload invalid logos #636

Vyvy-vi opened this issue Oct 18, 2022 · 0 comments · Fixed by #657
Labels
api

Comments

@Vyvy-vi
Copy link
Collaborator

Vyvy-vi commented Oct 18, 2022

Currently, the praise settings page allows admins to upload any file, and doesn't flag an error if the file is invalid.
It might be good if we add a simple error message in the "settings saved" component.

Screenshot 2022-10-18 at 2 52 10 PM

Screenshot 2022-10-18 at 2 51 57 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/kristofer_221103 givepraise/praise
2 participants
@kristoferlund @Vyvy-vi