Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: removed unused variables, exported name as a property of default import #381

Closed
wants to merge 3 commits into from

Conversation

bilalmirza74
Copy link
Contributor

Fix: removed unused variables, exported name as a property of default import

Other information:

eg: Did you discuss this change with anybody before working on it (not required, but can be a good idea for bigger changes). Any plans for the future, etc?

Checklist:

  • I have read the CONTRIBUTING guide.
  • I checked that there were not similar issues or PRs already open for this.
  • This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.

exported name as a property of default import
Copy link

vercel bot commented Oct 20, 2024

@bilalmirza74 is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

@jamesread
Copy link
Collaborator

Hey, this generally looks OK, but it's difficult to test because we don't yet have a unit testing framework.

How did you find these unused variables, using some sort of automated tool I assume?

@bilalmirza74
Copy link
Contributor Author

bilalmirza74 commented Oct 21, 2024

@jamesread I used some vs code extensions and this vs code suggestion pop-ups
image
image

@bilalmirza74
Copy link
Contributor Author

Running Good/Perfectly on my local machine too

@bilalmirza74 bilalmirza74 closed this by deleting the head repository Oct 22, 2024
@bilalmirza74
Copy link
Contributor Author

@jamesread can you open this for me and merge it accidentally deleted the repo because of that this pr got closed
or
should I open a new PR with this branch (gh pr checkout 381)

@bilalmirza74
Copy link
Contributor Author

@nevo-david is this looking good?

@jamesread
Copy link
Collaborator

jamesread commented Oct 29, 2024

Reopened, however, we cannot merge changes from the deleted repo.

Can you create a new repo and move the commits across?

jamesread added a commit that referenced this pull request Nov 5, 2024
Fix: removed unused variables, exported name as a property of default import #381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants