Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: removed unused variables, exported name as a property of default import #381 #411

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

bilalmirza74
Copy link
Contributor

@bilalmirza74 bilalmirza74 commented Oct 30, 2024

What kind of change does this PR introduce?

eg: Bug fix, feature, docs update, ...

Why was this change needed?

Please link to related issues when possible, and explain WHY you changed things, not WHAT you changed.

Other information:

eg: Did you discuss this change with anybody before working on it (not required, but can be a good idea for bigger changes). Any plans for the future, etc?

Checklist:

Put a "X" in the boxes below to indicate you have followed the checklist;

  • I have read the CONTRIBUTING guide.
  • I checked that there were not similar issues or PRs already open for this.
  • This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.

exported name as a property of default import
Copy link

vercel bot commented Oct 30, 2024

@bilalmirza74 is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

@bilalmirza74
Copy link
Contributor Author

@jamesread bro i reopen this pr take a look

@bilalmirza74
Copy link
Contributor Author

@jamesread @nevo-david
The devfest event is going to end soon if this PR is looking good please merge it asap

@jamesread
Copy link
Collaborator

jamesread commented Nov 5, 2024

@nevo-david , I'm a little anxious about merging this because it's quite difficult to test if this is going to break anything. I've run it, and it seems okay from a bit of clicking around, but I would normally have felt better by having tests.

If this breaks things, this is a pre-apology :-)

@bilalmirza74 thanks very much for the PR :-)

@jamesread jamesread merged commit b508282 into gitroomhq:main Nov 5, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants