Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In product changelog #381

Merged
merged 1 commit into from
Jul 21, 2022
Merged

In product changelog #381

merged 1 commit into from
Jul 21, 2022

Conversation

mustard-mh
Copy link

@mustard-mh mustard-mh commented Jul 13, 2022

This PR fixes gitpod-io/gitpod#7537

How to Test

  • Use preview env https://hw-vs-debug.preview.gitpod-dev.com and choose latest vscode as IDE
  • Open a workspace
  • It should display release notes after that workspace started
    • Fast command with Gitpod: Show Release Notes should make view force
    • Refresh after we close the release note tab, should not show it again
    • Open another workspace, should not show release notes automatically
  • Have Gitpod: Show Release Notes inside the menu/command panel

Something has done but can't test in preview env: Open workspace with Desktop VSCode, the read state of releaseNotes should remember once Setting Sync is enabled

Menu Command Panel
SCR-20220721-2y5 image

@akosyakov
Copy link
Member

We should use https://code.visualstudio.com/api/advanced-topics/remote-extensions#sync-user-global-state-between-machines to ensure that a user don’t see already seen changelog across different machines (local and Gitpod workspaces) Example

@mustard-mh mustard-mh force-pushed the hw/release branch 2 times, most recently from cec8894 to 82645d5 Compare July 20, 2022 09:25
@mustard-mh mustard-mh changed the title [WIP] In product changelog In product changelog Jul 20, 2022
@mustard-mh mustard-mh marked this pull request as ready for review July 20, 2022 09:26
@akosyakov
Copy link
Member

How can I try it?

@mustard-mh
Copy link
Author

How can I try it?

Will update description after werft success

@akosyakov
Copy link
Member

It would be good to add Release Notes to some prominent place in the main menu for VS Code Browser, next to documentation links.

@mustard-mh mustard-mh marked this pull request as draft July 20, 2022 10:15
@jeanp413 jeanp413 self-requested a review July 20, 2022 17:07
@mustard-mh mustard-mh marked this pull request as ready for review July 20, 2022 18:12
@jeanp413
Copy link
Member

Something has done but can't test in preview env: Open workspace with Desktop VSCode, the read state of releaseNotes should remember once Setting Sync is enabled

gp-code and vscode desktop uses different extensions so it will show again in vscode desktop, I think that's fine 👍

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes, @mustard-mh 🙏🧡!

Left some minor suggestions.

extensions/gitpod-shared/src/releaseNote.ts Outdated Show resolved Hide resolved
extensions/gitpod-shared/src/releaseNote.ts Outdated Show resolved Hide resolved
@mustard-mh
Copy link
Author

Rebased to main, fix minor from filiptronicek, and align changes in https://github.com/gitpod-io/gitpod-vscode-desktop

@mustard-mh mustard-mh merged commit 729682b into gp-code/main Jul 21, 2022
@akosyakov
Copy link
Member

@mustard-mh How do we verify that a new changelog is shown?

@mustard-mh
Copy link
Author

@mustard-mh How do we verify that a new changelog is shown?

@akosyakov Do you mean tracking data? Or how does it check if we need to show a new changelog?

@akosyakov
Copy link
Member

@akosyakov Do you mean tracking data? Or how does it check if we need to show a new changelog?

The latter.

@jeanp413 jeanp413 deleted the hw/release branch July 21, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants