-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In product changelog #381
In product changelog #381
Conversation
9d68ec9
to
99a52e9
Compare
We should use https://code.visualstudio.com/api/advanced-topics/remote-extensions#sync-user-global-state-between-machines to ensure that a user don’t see already seen changelog across different machines (local and Gitpod workspaces) Example |
cec8894
to
82645d5
Compare
How can I try it? |
Will update description after werft success |
It would be good to add |
gp-code and vscode desktop uses different extensions so it will show again in vscode desktop, I think that's fine 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the changes, @mustard-mh 🙏🧡!
Left some minor suggestions.
Rebased to main, fix minor from filiptronicek, and align changes in https://github.com/gitpod-io/gitpod-vscode-desktop |
@mustard-mh How do we verify that a new changelog is shown? |
@akosyakov Do you mean tracking data? Or how does it check if we need to show a new changelog? |
The latter. |
This PR fixes gitpod-io/gitpod#7537
How to Test
latest vscode
as IDEGitpod: Show Release Notes
should make view forceGitpod: Show Release Notes
inside the menu/command panelSomething has done but can't test in preview env: Open workspace with Desktop VSCode, the read state of releaseNotes should remember once Setting Sync is enabled