Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in product changelog #7

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Add in product changelog #7

merged 3 commits into from
Jul 20, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Jul 14, 2022

Description

TODO

Related Issue(s)

Fixes gitpod-io/gitpod#7537

How to test

Release Notes

NONE

Documentation

Incase you don't want to run it

Screenshot Light
image image

@jeanp413
Copy link
Member

Could you add some CSS magic 💄
image

@mustard-mh
Copy link
Contributor Author

Could you add some CSS magic 💄

@jeanp413 It's a TODO 🙈, do you have any suggested markdown CSS?

@jeanp413
Copy link
Member

lets's try first using the same css as vscode release notes an then we can iterate from there if necessary, check src/vs/workbench/contrib/markdown/browser/markdownDocumentRenderer.ts in vscode

@jeanp413
Copy link
Member

jeanp413 commented Jul 14, 2022

Nice 👌, not sure about the image because it takes too much screen space but other than that it looks really good

@jeanp413
Copy link
Member

@loujaybee @akosyakov thoughs about the image, should we keep it or not?

@jeanp413 jeanp413 self-requested a review July 15, 2022 18:23
@akosyakov
Copy link
Member

@loujaybee @akosyakov thought about the image, should we keep it or not?

I think updates to the content should be done directly in Changelog. I would like to see list of highlights and call out to use latest versions in each changelog at the top. Images should go to specific highlights below. cc @Cahllagerfeld @mikenikles

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jeanp413
Copy link
Member

jeanp413 commented Jul 18, 2022

I think updates to the content should be done directly in Changelog.

Not sure what you mean, are you referring to the replace() calls?

I would like to see list of highlights and call out to use latest versions in each changelog at the top. Images should go to specific highlights below

We are using the same markdown, if you mean to change the markdown template/format then that should be a different issue in the website repo as it will also affect it

@akosyakov
Copy link
Member

Not sure what you mean, are you referring to the replace() calls?

No i mean decisions about the actual content, not format, i.e. what to put at the top.

@akosyakov
Copy link
Member

We should use https://code.visualstudio.com/api/advanced-topics/remote-extensions#sync-user-global-state-between-machines to ensure that a user don’t see already seen changelog across different machines (local and Gitpod workspaces) Example

@mustard-mh mustard-mh force-pushed the hw/changelog branch 2 times, most recently from 36a429d to 5ffa497 Compare July 20, 2022 08:46
@mustard-mh mustard-mh changed the title [WIP] add in product changelog Add in product changelog Jul 20, 2022
@mustard-mh mustard-mh marked this pull request as ready for review July 20, 2022 08:47
@mustard-mh mustard-mh marked this pull request as draft July 20, 2022 09:03
@mustard-mh mustard-mh marked this pull request as ready for review July 20, 2022 09:27
@@ -0,0 +1,318 @@
/*---------------------------------------------------------------------------------------------
Copy link
Member

@akosyakov akosyakov Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should consider to extract a package and publish it to npm to share between VS Code Browser and Desktop? It can be done separately. But please file a tech-debt issue on gitpod-io.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be gitpod-shared

@jeanp413
Copy link
Member

@mustard-mh we need to implement a basic caching here using the cache-header value, as the extension runs in node not the browser, you can use storage APi and store the timestap of the last fetch call

@jeanp413 jeanp413 merged commit a9b5a0f into master Jul 20, 2022
@jeanp413 jeanp413 deleted the hw/changelog branch July 20, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic: In Product Changelog - VS Code only
3 participants