Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Get Started with Gitpod walkthrough #110

Merged
merged 5 commits into from
Oct 7, 2021

Conversation

mikenikles
Copy link

How to test

  1. Preview in web
  2. On the Welcome screen, look for the new walkthrough on the right side
  3. Review the walkthrough, click links and verify everything works as expected

To reset the walkthrough progress, use the command palette and search for "Developer: Reset Welcome Page Walkthrough Progress"

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!
LGTM ✅

Welcome.-.openvscode-server.-.Gitpod.Code.Dev.mp4

@phimae
Copy link

phimae commented Sep 30, 2021

The first and last sentence of the browser extension paragraph are redundant
image

Should there be any mentioning of the workspace sharing and snapshot feature? Maybe together with the open ports section?

@mikenikles
Copy link
Author

mikenikles commented Sep 30, 2021

See gitpod-io/gitpod#5964 (comment) for screenshots of the changes made in 8d8c223

@akosyakov
Copy link
Member

@mikenikles Is it good to rebase and land? or someone else should look at it?

btw if you want to release it in stable next week then we should cherry-pick it to gp-code/release/1.61 as well.

@loujaybee loujaybee self-assigned this Oct 6, 2021
@mikenikles
Copy link
Author

mikenikles commented Oct 6, 2021

Let's merge it. It's been reviewed by a few people and we already have gitpod-io/gitpod#5964 with follow up ideas :).

Landing it next week would be incredible!

@akosyakov akosyakov force-pushed the mikenikles/add-welcome-walkthrough branch from 48daf30 to d5e1b5f Compare October 7, 2021 06:41
@akosyakov akosyakov merged commit 41dd4f7 into gp-code/main Oct 7, 2021
@akosyakov akosyakov deleted the mikenikles/add-welcome-walkthrough branch October 7, 2021 06:48
@akosyakov
Copy link
Member

Merged and cherry picked on 1.61. Going to release it as a part of insiders today.

@mikenikles
Copy link
Author

Thank you Anton 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants