-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code] Gitpod walkthrough #6095
Conversation
@mikenikles does it resolve #5964? |
@mikenikles I tried it but it somehow broken, I cannot click on links in the walkthrough. |
Nope, #5964 is a follow-up with a few enhancements. I don't think there's an open issue for the work in this PR. Regular hyperlinks to docs etc seem to work, the two that are now broken for some reason are the ones that execute a command, e.g. open the ports panel or run a terminal command. I'm looking into it 👀 Update: I spent another hour looking into it. This was tested by various people in the openvscode-server repo PR. Even when I try it in that repo, the commands no longer work now. I tested with stable and Insider VS Code, same problem. I also don't see anything in the logs. At this point, I can't explain what's going on. Maybe a good night's sleep and another look tomorrow will reveal more. |
Maybe I broke something while rebasing, could you try again in openvscode-server directly? |
/werft run 👍 started the job as gitpod-build-ak-gitpod-walkthrough.1 |
/lgtm |
LGTM label has been added. Git tree hash: 4a0f2090a00d7e1e8d745141c4ca282a545044a0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: corneliusludmann Associated issue: #5964 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Update latest VS Code to bring Gitpod walkthrough: gitpod-io/openvscode-server#110
Gitpod Code commit: gitpod-io/openvscode-server@128bab1
Related Issue(s)
Related to #5964
How to test
Release Notes