Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitbucket-server] add to Git Integrations UI #9135

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Apr 5, 2022

This PR adds the option to setup an integration for a self-managed Bitbucket Server in user's account.

Resolves #9010

A notice on the limited compatibility is included in the Git Integrations modal.

Screen Shot 2022-04-11 at 10 45 43

Connect to self-managed Bitbucket Server in Git Integration modal.

@AlexTugarev AlexTugarev force-pushed the alex/configuration-ui-to-register-9010 branch 2 times, most recently from 02b733b to df8c8fc Compare April 5, 2022 14:58
@jldec jldec added the team: webapp Issue belongs to the WebApp team label Apr 8, 2022
@jldec
Copy link
Contributor

jldec commented Apr 8, 2022

Following instructions at https://confluence.atlassian.com/bitbucketserver0720/configure-an-incoming-link-1116282013.html

I can’t get past this - it looks like maybe it doesn’t like the space as the start of the scopes used in the request.
Screenshot 2022-04-08 at 14 44 22

The BBS Application link is configured with the following:

Screenshot 2022-04-08 at 15 06 22

@AlexTugarev AlexTugarev force-pushed the alex/configuration-ui-to-register-9010 branch from df8c8fc to 1448afc Compare April 11, 2022 08:46
@AlexTugarev AlexTugarev marked this pull request as ready for review April 11, 2022 08:52
@AlexTugarev AlexTugarev requested a review from a team April 11, 2022 08:52
@AlexTugarev
Copy link
Member Author

@jldec, please check again!

@AlexTugarev AlexTugarev force-pushed the alex/configuration-ui-to-register-9010 branch from 1448afc to 7604e45 Compare April 12, 2022 06:36
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful - this works for me now - thanks @AlexTugarev
/hold in case you need review of the code as well from another engineer.

I used the following scopes when setting up the incoming OAuth application link on the BBS server side - can you confirm that all are required?

Screenshot 2022-04-12 at 09 53 17

@AlexTugarev
Copy link
Member Author

AlexTugarev commented Apr 12, 2022

/hold cancel

thanks! 🎉

@roboquat roboquat merged commit ef14acd into main Apr 12, 2022
@roboquat roboquat deleted the alex/configuration-ui-to-register-9010 branch April 12, 2022 18:19
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration UI to register Bitbucket Server instance
4 participants