Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording on new Git integration page incorrect #9873

Closed
mrsimonemms opened this issue May 9, 2022 · 6 comments · Fixed by #13588
Closed

Wording on new Git integration page incorrect #9873

mrsimonemms opened this issue May 9, 2022 · 6 comments · Fixed by #13588
Assignees
Labels
meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@mrsimonemms
Copy link
Contributor

Bug description

The "new Git integration" page says "configure a GitLab or GitHub instance", but Bitbucket is now available.

image

Steps to reproduce

Go to a fresh installation with no integrations configured

Workspace affected

No response

Expected behavior

Should say "configure a GitLab, GitHub or Bitbucket instance"

Example repository

No response

Anything else?

No response

@mrsimonemms mrsimonemms added the bug label May 9, 2022
@mrsimonemms mrsimonemms added the team: webapp Issue belongs to the WebApp team label May 9, 2022
@gtsiolis gtsiolis added type: bug Something isn't working and removed bug labels May 9, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented May 9, 2022

This seems to be different from what is visible in production in /integrations. In case the same options are available also in self hosted we could probably use the same copy here.

Cc @AlexTugarev @jldec because #9135.

Integrations > New Git Integration
Screenshot 2022-05-09 at 7 37 00 PM

@jldec
Copy link
Contributor

jldec commented May 11, 2022

@mrsimonemms is this just a case of the self-hosted release being behind the commits on gitpod main?
If so, we don't need this issue right?

@gtsiolis
Copy link
Contributor

gtsiolis commented May 11, 2022

@jldec I had the same thought but it seems we still use the old copy here in the setup step. Cc @AlexTugarev

const headerText = "Configure a Git integration with a GitLab or GitHub instance.";

Also, re-posting from #9873 (comment):

In case the same options are available also in self hosted we could probably use the same copy here.

@stale
Copy link

stale bot commented Aug 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Aug 11, 2022
@mrsimonemms
Copy link
Contributor Author

@jldec seemingly not. This is from the September release candidate of Self-Hosted
image

@mrsimonemms mrsimonemms removed the meta: stale This issue/PR is stale and will be closed soon label Sep 30, 2022
@jldec jldec moved this to Scheduled in 🍎 WebApp Team Sep 30, 2022
@jldec jldec added the meta: never-stale This issue can never become stale label Sep 30, 2022
@jldec
Copy link
Contributor

jldec commented Sep 30, 2022

Scheduled

@laushinka laushinka self-assigned this Oct 4, 2022
@laushinka laushinka moved this from Scheduled to In Progress in 🍎 WebApp Team Oct 4, 2022
Repository owner moved this from In Progress to In Validation in 🍎 WebApp Team Oct 5, 2022
@laushinka laushinka moved this from In Validation to Done in 🍎 WebApp Team Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants