Remove checkoutLocation from StartWorkspaceReq #9007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@csweichel I have fixed the outstanding issues. |
github-actions
bot
added
team: webapp
sagor999
reviewed
Apr 4, 2022
sagor999
previously approved these changes
Apr 5, 2022
easyCZ
previously approved these changes
Apr 5, 2022
geropl
reviewed
Apr 5, 2022
| result.setBackup(new FromBackupInitializer()); | ||
| const backup = new FromBackupInitializer(); | ||
| if (CommitContext.is(context)) { | ||
| backup.setCheckoutLocation(context.checkoutLocation || ""); |
There was a problem hiding this comment.
Being picky here bc we had an incident after the last change in the multirepo PR
There was a problem hiding this comment.
Shouldn't we default to "."?
Also in all cases, even if not a CommitContext?
There was a problem hiding this comment.
@csweichel Could you double-check here?
There was a problem hiding this comment.
@AlexTugarev This could be the problematic lines, actually. ☝️
easyCZ
approved these changes
Apr 7, 2022
sagor999
approved these changes
Apr 7, 2022
aledbf
approved these changes
Apr 7, 2022
geropl
approved these changes
Apr 7, 2022
roboquat
added
the
deployed: workspace
|
Hi! Was this change tested with a restart of a workspace? |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the redundant
checkoutLocationfield from theStartWorkspacerequest. Checkout location is a concept that exists on the content initializer, not on the workspace itself.Related Issue(s)
Fixes #7370
Related #8888
How to test
Release Notes