Source changes not reflected in dashboard overview

[Foxhoundn]

Bug description

Source changes not reflected in dashboard overview

Happened to 2 different workspaces, one older, one brand new.

Steps to reproduce

I reproduced by simply making changes in a workspace and then checked the dashboard.

Workspace affected

blue-raccoon-uzfqkexx

Expected behavior

It's really important that the changes are shown in the column, or that the column is not there (either is fine), since I trusted it and deleted a workspace that unfortunately had changes in it.

Example repository

No response

Anything else?

No response

[iQQBot]

I sometimes encounter

[ionutale]

is not shown if the workspace is running, if you close the workspace it works fine

[Foxhoundn]

is now shown if the workspace is running, if you close the workspace it works fine

Nope

[buggtb]

I've seen similar to the above, in my case I found it instead of deleting it, but its also not entirely obvious whats going on. In my workspace list I've opened the workspace that says no changes, but does have the changes I was infact looking for. But the same project further down on a different workspace says it has changes, which it does, but were just intellij workspace updates. So the latter was correct, but the open workspace was incorrect and showing no changes, which makes it hard to find what you're after.

[danieldietrich]

We experience the same bug (running on Gitpod Self-Hosted v0.10.0). We see weird behavior:

• when opening the dashboard, there was one pinned workspace and changes were correctly shown
• once starting that workspace, it reverted to "No changes", although the same changes existed
• when making even more changes, those were not reflected (after workspace stop)
• once pinning a workspace (that has changes displayed), it reverts to "no changes". Starting/stopping/unpinning does not help. Changes are never detected again.
• however, for a fresh workspace, changes are displayed correctly

[geropl]

I reproduced by simply making changes in a workspace and then checked the dashboard.

So far Gitpod only detects "changes" when making the backup, e.g. when it is stopped. We should definitely make this clear in the UI. E.g., by not showing "no changes" if the workspace is running, for instance.

@gtsiolis I bet you have better suggestions how to visualize this state? 🤔

[ionutale]

What kind of git are you using? Got lab, GitHub, bitbucket, selfhosted? Il giorno ven 4 mar 2022 alle 18:10 Daniel Dietrich < ***@***.***> ha scritto:

…

We experience the same bug (running on Gitpod Self-Hosted v0.10.0). We see weird behavior: - when opening the dashboard, there was one pinned workspace and changes were correctly shown - once starting that workspace, it reverted to "No changes", although the same changes existed - when making even more changes, those were not reflected (after workspace stop) - once pinning a workspace (that has changes displayed), it reverts to "no changes". Starting/stopping/unpinning does not help. Changes are never detected again. - however, for a fresh workspace, changes are displayed correctly — Reply to this email directly, view it on GitHub <#7370 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATRTF7Z7FASHMVUEHORROLU6I7W7ANCNFSM5K2M66HQ> . You are receiving this because you commented.Message ID: ***@***.***>

[danieldietrich]

Hi @ionutale, we are using self-hosted with the generic-auth-provider (connected to our own oauth2 identity provider) in conjunction with the GitHub identity provider (GitHub accounts can be connected from within the app).

This works very well, we use the Gitpod functionality here which comes off the shelve. However, in some cases the workspace changes aren't reflected anymore in the dashboard, even if the backup is performed by stopping the workspace.

Note: I haven't tested yet, if the behavior is the same with the latest public Gitpod release - I will do that.

[ionutale]

The self hosted is GitLab, bitbucket, GitHub? Il giorno gio 10 mar 2022 alle 16:52 Daniel Dietrich < ***@***.***> ha scritto:

…

Hi @ionutale <https://github.com/ionutale>, we are using self-hosted with the generic-auth-provider (connected to our own oauth2 identity provider) *in conjunction with* the GitHub identity provider (GitHub accounts can be connected from within the app). This works very well, we use the Gitpod functionality here which comes off the shelve. However, in some cases the workspace changes aren't reflected anymore in the dashboard, even if the backup is performed by stopping the workspace. Note: I haven't tested yet, if the behavior is the same with the latest public Gitpod release - I will do that. — Reply to this email directly, view it on GitHub <#7370 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATRTF2NUDIBYNP2IR7SKELU7ILDZANCNFSM5K2M66HQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[randomir]

Reproduction steps in GP 0.10:

1. create a new workspace
2. modify a file (or type touch x in terminal)
3. stop the workspace. Changes are correctly listed on the "Stopped" page.
4. navigate to dashboard - changes are displayed for the workspace
5. now start the same workspace again
6. stop it. Now changes are not displayed on the "Stopped" page (it says "No Changes")
7. navigate to dashboard - chnage are not displayed anymore

Can't reproduce it on gitpod.io. Over there, changes are not detected/listed on the workspace "Stopped" page, nor on the dashboard up to at least 10min after the workspace has been stopped.

[geropl]

Thx @randomir for the nice repro, can reproduce on gitpod.io. Looking at the DB we just don't have the info for workspace instances except the 1st one we started.

@kylos101 This ☝️ makes this an issue for team workspace.

It seems that ws-manager is emitting repo info (like below) only on the 1st stop of a workspace, but not on consecutive stops:

    "repo": {
        "branch": "master",
        "latestCommit": "6fec40a2ed76dfccdeb8b911cb38978c630a6077",
        "untrackedFiles": [
            "newfile"
        ],
        "totalUntrackedFiles": 1,
        "totalUncommitedFiles": 0,
        "totalUnpushedCommits": 0
    },

[gtsiolis]

Looking at the DB we just don't have the info for workspace instances except the 1st one we started.

Nice catch, @buggtb! I could also reproduce what @randomir described in #7370 (comment).

Thanks @geropl for also confirming this bug in #7370 (comment).

So far Gitpod only detects "changes" when making the backup, e.g. when it is stopped. We should definitely make this clear in the UI. E.g., by not showing "no changes" if the workspace is running, for instance.

@geropl is correct here, we could improve this on the dashboard as currently we're showing No Changes for workspaces that can include changes regardless if this is the first time opening one or re-opening a stopped one. Probably something to consider while we're working on improving the workspaces list in general. Cc @jldec 💭

[kylos101]

Hi @geropl , thanks for the heads up, I've scheduled this accordingly.

[mjaindwave]

Thank you @kylos101 for looking into it. Do you have an ETA on this? We have a release coming up and our customers are going to be affected by this bug.

[kylos101]

Hi @mjaindwave , the work is scheduled, but, we haven't started it yet. It may start this week, but, that is not certain.

Also, next week for Gitpod is kind of like a holiday, many of us will be traveling or in training.

For the meantime, may I ask, how will this impact your customers?