-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] lint warnings: NewProject.tsx #8842
[dashboard] lint warnings: NewProject.tsx #8842
Conversation
To be used for anchor tags that should've been buttons because they don't really bring the user to any new location.
LGTM on first glance, though I'd love more feedback from someone who has worked on this code last. |
👀🤞 @jankeromnes |
Weekly ping to @jankeromnes 🤣 |
Oh no 🙈 I thought I was better than that at noticing the pings. Having a look 👀 EDIT: Putting this on my "to review" list for tomorrow morning 📝 |
Okay, let's have a look 👀 thanks for your patience! /werft run 👎 cannot start job - please talk to whoever's in charge of your Werft installation |
Oh no, werft's a it again!
I try to keep branch names short, but all the stuff gitpod and werft (?) add makes it difficult... could this 63 characters cap be raised a bit? Brb renaming the branch. |
Indeed, sorry about that @trumbitta -- FYI, I've bypassed the branch name problem by pushing your commit directly to a shorter Gitpod branch. 😇 As you can see, Werft is now running. |
I also renamed the original branch and was going to open a new PR (I had hoped GitHub would cascade the name change but it didn't). Let me know if you need me to do something about it! |
@jankeromnes I see that me renaming the branch also had GitHub closing the PR. What do you want me to do? |
Yes, GitHub doesn't support renaming PR branches for some reason. 😅
Yes please! 🙏 (I didn't open a PR, but simply pushed your commit to this branch, which had the effect of making Werft build the commit without issues and even report the status here in this PR, since the commits were identical) |
Description
As per https://discord.com/channels/816244985187008514/885406100436951080/953232219261009950
This fixes the first bits of lint warnings.
Specifically:
.gp-link
Tailwind class to make buttons mimic links and avoid using<a href="javascript:void(0)" ...>
projects/NewProject.tsx
Related Issue(s)
Re #3841
How to test
projects/NewProject.tsx
Release Notes
Documentation