-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] Lint warnings #3841
Comments
We should probably turn these warnings into errors. Also, in order not to suddenly break everyone's build, maybe we can add problematic files to a |
I'm going to work on this after #7757 if it's still available 💪 |
Ok #8655 landed and I can confirm I'm pretty much ready (and pumped) to start working on this |
@trumbitta That would be nice. And thanks again for basically initiating the internal prettier discussion. 😉 |
Hey @gtsiolis @trumbitta @svenefftinge I'd love to work on this! |
No problem for me 🍻 |
Cool! We just yesterday talked about prioritizing this. 🙏 |
For sure @svenefftinge will come out with a PR soon! Also how would you suggest I go about the PRs...should I break it down into many (each solving a particular type of warning) or just one PR with all the changes! |
IMO the scope should make sense for you as author, but please keep in mind that it needs to be reviewable. So maybe one per page / big component / section of the UI (for example: personal settings?) |
Ohhh got it, yup it certainly does, thank you so much! @gtsiolis @trumbitta I'm absolutely loving working on this PR....I've learnt so much on how the frontend side of Gitpod works...super duper cool stuff...thanks for assigning this to me! |
Hey @gtsiolis ,just a part of this is completed and there's a lot to do...maybe the bot misunderstood haha🙃 Could you please open this again? Thank you! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bug description
Steps to reproduce
Requires changes from #3830
Run
craco build
Expected behavior
Example repository
The text was updated successfully, but these errors were encountered: