Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a Global Prettier File #8607

Closed
wants to merge 7 commits into from
Closed

Created a Global Prettier File #8607

wants to merge 7 commits into from

Conversation

Harry-Hopkinson
Copy link
Contributor

Description

I have created a global .prettierrc.js file for Typescript and Js Files in order to remove inconsistent linting configurations which spanned across files.

@Harry-Hopkinson Harry-Hopkinson requested a review from a team March 4, 2022 16:32
@roboquat
Copy link
Contributor

roboquat commented Mar 4, 2022

@Harry-Hopkinson: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roboquat roboquat added size/M and removed size/S labels Mar 12, 2022
@roboquat roboquat added size/S and removed size/M labels Mar 12, 2022
@Harry-Hopkinson
Copy link
Contributor Author

Harry-Hopkinson commented Mar 12, 2022

@mustard-mh should be ready for review 😄

@easyCZ
Copy link
Member

easyCZ commented Mar 13, 2022

There's a json version of prettier config in the repo. Perhaps makes sense to extend that one with the options proposed here.

@Harry-Hopkinson
Copy link
Contributor Author

Oh I did notice, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants