Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a global prettier file to remove inconsistent linting configurations. #8581

Closed
wants to merge 1 commit into from

Conversation

Harry-Hopkinson
Copy link
Contributor

Description

I have created a global .prettierrc.js file for Typescript and Js Files in order to remove inconsistent linting configurations which spanned across files.

@Harry-Hopkinson Harry-Hopkinson requested review from a team March 3, 2022 20:11
@Harry-Hopkinson Harry-Hopkinson requested a review from a team March 3, 2022 20:11
@roboquat
Copy link
Contributor

roboquat commented Mar 3, 2022

@Harry-Hopkinson: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Harry-Hopkinson
Copy link
Contributor Author

I have ran

prettier --config ./.prettierrc.js --write "./**/*.ts"
prettier --config ./.prettierrc.js --write "./**/*.tsx"
prettier --config ./.prettierrc.js --write "./**/*.js"

@mustard-mh
Copy link
Contributor

mustard-mh commented Mar 4, 2022

Thanks! I want this linting too! 😄 #7653 (comment)

I think you can create a PR with .prettierrc.js file added only, then let members run re-format command
Too many files to review now

@Harry-Hopkinson
Copy link
Contributor Author

@mustard-mh I will do just that.

@Harry-Hopkinson Harry-Hopkinson requested review from a team March 4, 2022 16:14
@roboquat roboquat added size/XS and removed size/XXL labels Mar 4, 2022
@Harry-Hopkinson
Copy link
Contributor Author

Continued #8607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants