[ws-manager] Wait for workspace pod to be ready #8289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8289 +/- ##
==========================================
+ Coverage 31.23% 33.52% +2.28%
==========================================
Files 39 31 -8
Lines 5910 4567 -1343
==========================================
- Hits 1846 1531 -315
+ Misses 3923 2920 -1003
+ Partials 141 116 -25
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
kylos101
reviewed
Feb 17, 2022
sagor999
force-pushed
the
pavel/oom-fix
branch
from
b866d4a to
4bb5490
Compare
|
/hold |
princerachit
approved these changes
Feb 18, 2022
csweichel
approved these changes
Feb 18, 2022
|
/unhold |
This was referenced Feb 18, 2022
Open
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure to wait for container to start up, in case of out of memory or other errors.
Related Issue(s)
Fixes #8253
How to test
Spin up new cluster in workspace preview env:
./new-vm.sh -v pavel-oom-fix.6 -z us-west1-cstart the workspace. it should start without issues.
now cordon the node (since we cannot simulate oom error reliably)
try to start workspace. observe pod is created and pending. after 5 seconds ws-manager will delete the pending pod (since it is considered failed now), and will create a new one.
uncordon the node.
observe pod was created. you should be able to load into your workspace now.
caveat: if you leave node cordoned for longer than 30 seconds, then startWorkspace context will get cancelled and server will attempt to create workspace again.
Release Notes
Documentation