-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-manager] Wait for workspace pod to be ready #8258
Conversation
/werft with-clean-slate-deployment 👎 unknown command: with-clean-slate-deployment |
/werft help 👍 You can interact with werft using:
|
/werft run 👍 started the job as gitpod-build-aledbf-wait.10 |
Co-authored-by: utam0k <[email protected]>
This would help with the problem we're trying to solve, but most likely deteriorate the feedback mechanism towards the user by all but removing the How much of a concern that is is something we'd see in practice. |
I reduced exponential backoff factor, as otherwise in worst case scenario it would have been waiting for hours there to retry. |
@@ -199,7 +199,7 @@ func (m *Manager) StartWorkspace(ctx context.Context, req *api.StartWorkspaceReq | |||
backoff := wait.Backoff{ | |||
Steps: 10, | |||
Duration: 100 * time.Millisecond, | |||
Factor: 5.0, | |||
Factor: 2.5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to leverage the cap
property for backoff? I believe it's intent is to ensure the duration does't exceed a certain time limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we could do that as well. What would be a reasonable cap? 5 min?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 5 minutes will do.
We can always bring it down if we need, but this way it's a predictable experience.
W/o accounting for sleep (and jitter), that would get users to iteration 8 (but not beyond) here: https://go.dev/play/p/dtUxS6TwTrw
Continue working in new PR (due to werft issues in this one): #8289 |
Description
Make sure to wait for container to start up, in case of out of memory or other errors.
Related Issue(s)
Fixes #8253
How to test
Spin up new cluster in workspace preview env:
./new-vm.sh -v aledbf-wait.10 -z us-west1-c
then try to start up workspaces in it.
Release Notes
Documentation